snappy-hwe-snaps

Merge ~alfonsosanchezbeato/snappy-hwe-snaps/+git/network-manager:add-mm-support into ~snappy-hwe-team/snappy-hwe-snaps/+git/network-manager:master

  1. Git
  2. lp:~alfonsosanchezbeato/snappy-hwe-snaps/+git/network-manager
  3. add-mm-support
  4. Merge into master
Proposed by Alfonso Sanchez-Beato
Status: Merged
Approved by: Simon Fels
Approved revision: 987e2b29e547665af32e66dad4eaf1f425048d86
Merged at revision: 5ce4e01aed3df71b62077ea652f27bd1aa0f3572
Proposed branch: ~alfonsosanchezbeato/snappy-hwe-snaps/+git/network-manager:add-mm-support
Merge into: ~snappy-hwe-team/snappy-hwe-snaps/+git/network-manager:master
Diff against target: 237 lines (+85/-30)
3 files modified
bin/networkmanager (+2/-0)
patches/0001-Add-support-for-Ubuntu-Snappy.patch (+78/-28)
snapcraft.yaml (+5/-2)
Reviewer Review Type Date Requested Status
Simon Fels Approve
Review via email: mp+295743@code.staging.launchpad.net

Commit message

Add support for ppp and plug for modem-manager

Description of the change

Add support for ppp and plug for modem-manager

To post a comment you must log in.
Revision history for this message
Simon Fels (morphis) wrote :

Comments in line.

review: Needs Fixing
Revision history for this message
Alfonso Sanchez-Beato (alfonsosanchezbeato) wrote :

See comments below.

Revision history for this message
Alfonso Sanchez-Beato (alfonsosanchezbeato) wrote :

See additional comment.

Revision history for this message
Simon Fels (morphis) :
review: Needs Fixing
Revision history for this message
Alfonso Sanchez-Beato (alfonsosanchezbeato) wrote :

MP refreshed

Revision history for this message
Simon Fels (morphis) :
review: Needs Fixing
Revision history for this message
Alfonso Sanchez-Beato (alfonsosanchezbeato) wrote :

See inline comment.

Revision history for this message
Simon Fels (morphis) :
Revision history for this message
Alfonso Sanchez-Beato (alfonsosanchezbeato) wrote :

PR refreshed

Revision history for this message
Simon Fels (morphis) wrote :

LGTM

review: Approve
Revision history for this message
Simon Fels (morphis) wrote :

Patch needs rework as it has merge conflicts.

Revision history for this message
Alfonso Sanchez-Beato (alfonsosanchezbeato) wrote :

Refreshed

There was an error fetching revisions from git servers. Please try again in a few minutes. If the problem persists, contact Launchpad support.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches