lp:~alfonsosanchezbeato/snappy-hwe-snaps/+git/network-manager

Author: Alfonso Sanchez-Beato
Author Date: 2023-03-24 17:57:31 UTC

patch: core: do not check 'match' settings when comparing connections

Match settings are already used for matching an existing connection to
a device, it does not really make sense to compare them with an
auto-generated connection that is not going to have them.

Author: Alfonso Sanchez-Beato
Author Date: 2023-02-20 16:39:55 UTC

spread.yaml: include gce backend

Author: Alfonso Sanchez-Beato
Author Date: 2023-02-09 11:15:55 UTC

workflows/tests: pass LP credentials to action with env var

Author: Alfonso Sanchez-Beato
Author Date: 2023-01-26 14:56:19 UTC

Revert to self-hosted

Author: Alfonso Sanchez-Beato
Author Date: 2023-01-10 10:52:03 UTC

snap-patch/netplan: do not write external or generated connections

See
https://developer-old.gnome.org/NetworkManager/stable/nm-dbus-types.html#NMSettingsConnectionFlags

Author: Alfonso Sanchez-Beato
Author Date: 2022-12-09 14:33:04 UTC

hooks/remove: prevent re-apperance of 00-default-nm-renderer.yaml on removal

Author: Alfonso Sanchez-Beato
Author Date: 2022-12-01 18:31:18 UTC

hooks/remove: wait a bit before applying netplan configuration

Apparently when the call to io.netplan.Netplan.Generate returns it has
not necessarily performed all changes in the filesystem, which is
arguably a bug. Let's wait a bit as a workaround.

Author: Alfonso Sanchez-Beato
Author Date: 2022-11-08 11:10:08 UTC

Check for ModemManager same or newer than 1.18

We are shipping focal's MM client library in the network-manager
snap. The library will fail if talking to an older verions of MM
daemon than the one for the library, which is an issue as focal has
updated MM from 1.16 to 1.18, so NM would fail to use modems if there
are old versions of the MM snap in the system. To prevent this
problem, check for the MM version in post-refresh and install hooks
and fail if the MM daemon is not modern enough.

Author: Alfonso Sanchez-Beato
Author Date: 2022-06-21 07:59:33 UTC

tests/full/system-network-is-active: add reference to LP bug

Author: Alfonso Sanchez-Beato
Author Date: 2022-05-02 16:18:44 UTC

Change grade to stable as core22 is now released

Author: System Enablement CI Bot
Author Date: 2022-04-20 10:30:11 UTC

Open development for 1.36.4-2-dev

Author: Alfonso Sanchez-Beato
Author Date: 2022-04-19 10:50:43 UTC

Disable test-keyfile-settings test for the moment

Author: System Enablement CI Bot
Author Date: 2022-03-04 09:49:59 UTC

Open development for 1.22.10-12-dev

Author: Alfonso Sanchez-Beato
Author Date: 2022-01-10 11:29:42 UTC

Prime all docs from primed packages

Prime all docs from primed packages, not only the copyright. This
seems a saner option as we have the full changelog for the packages
and other possibly important files for attribution, even though there
is a slight size increase for the snap.

Author: Alfonso Sanchez-Beato
Author Date: 2021-11-10 16:03:20 UTC

Add sleep

Author: Alfonso Sanchez-Beato
Author Date: 2021-06-25 15:03:26 UTC

Fix repo in snap description

Author: Alfonso Sanchez-Beato
Author Date: 2021-04-05 10:39:49 UTC

Copy latest template for test runner

Needed as yq changed syntax.

Author: Alfonso Sanchez-Beato
Author Date: 2021-03-12 14:19:52 UTC

Revert "spread: fix tests to work with epochs"

This reverts commit bd2e479614ec595050aaf4f0f63f6aec12adc095.
The change was needed so tests could run after changing the
epoch. However, this caused races as connections happen after the snap
is installed, and NM starts without all the permissions it
needs. Revert this back as now we have an epoch 1 snap already
published in 20/beta and we can install it without errors.

Author: Alfonso Sanchez-Beato
Author Date: 2021-02-17 13:31:08 UTC

Adapt tests to netplan plugin

The netplan plugin requires some changes for the tests to
run. However, some of this will need to be reverted when we get the
new netplan plugin with passthrough support. See
https://code.launchpad.net/~hellsworth/snappy-hwe-snaps/+git/network-manager/+merge/396213
for more information.

Author: Alfonso Sanchez-Beato
Author Date: 2020-11-23 07:56:09 UTC

[backport,src-branch] platform: use also statvfs() to check for udevd

Check whether or not there is a running udevd by using statvfs() on
"/sys" and use access() as a fallback. This is in line with what is
done by systemd [1] and helps in case NM is not really running in a
container but has been confined by a MAC so it does not have full
access to sysfs (access() returns EACCES). Fixes LP:#1712918,
LP:#1893184.

Upstream:
https://gitlab.freedesktop.org/NetworkManager/NetworkManager/-/commit/9c8275bedcc98d789fa83d2817b9e8ff58f3e7b6

MP: https://code.launchpad.net/~alfonsosanchezbeato/snappy-hwe-snaps/+git/network-manager/+merge/394268

[1] https://github.com/systemd/systemd/blob/v246/src/basic/stat-util.c#L132

Author: Alfonso Sanchez-Beato
Author Date: 2020-10-06 16:30:11 UTC

platform: use also statvfs() to check for udevd

Check whether or not there is a running udevd by using statvfs() on
"/sys" and use access() as a fallback. This is in line with what is
done by systemd [1] and helps in case NM is not really running in a
container but has been confined by a MAC so it does not have full
access to sysfs (access() returns EACCES). Fixes LP:#1712918,
LP:#1893184.

Upstream: https://gitlab.freedesktop.org/NetworkManager/NetworkManager/-/commit/9c8275bedcc98d789fa83d2817b9e8ff58f3e7b6

[1] https://github.com/systemd/systemd/blob/v246/src/basic/stat-util.c#L132

Author: Alfonso Sanchez-Beato
Author Date: 2020-11-18 18:32:07 UTC

Fix typo (gfree -> g_free)

Author: Alfonso Sanchez-Beato
Author Date: 2020-07-14 13:18:32 UTC

snapcraft.yaml: build wait-more-for-pppd branch

Author: Alfonso Sanchez-Beato
Author Date: 2020-07-14 13:06:35 UTC

ppp-manager: wait 10 seconds until killing pppd

This gives some space for retrials on the pppd size.

Author: Alfonso Sanchez-Beato
Author Date: 2020-06-30 07:31:14 UTC

Build from test branch

Author: Alfonso Sanchez-Beato
Author Date: 2020-07-07 11:19:12 UTC

run-tests: take now stack-snaps-tools instead of tests-extras

Author: Alfonso Sanchez-Beato
Author Date: 2020-07-07 07:50:16 UTC

run-tests: pass arguments to tests-runner

Author: Alfonso Sanchez-Beato
Author Date: 2019-06-13 16:23:21 UTC

core/pppd-plugin: wait to recover port settings before notifying death

pppd restores the previous settings for the serial port it uses right
before exiting. It is especially important to do so because otherwise
ModemManager is not able to recover the port as it can receive a hangup
event from the port due to CLOCAL not being restored. However, there is
currently a race condition that produces this issue. This is because
when PHASE_DEAD is notified, pppd still has not restored the port
settings - it does that a bit later, in the die() function.

This patch delays notifying PHASE_DEAD until when the exitnotify() hook
is called by pppd: when this happens the port settings have already been
restored.

There were previously efforts to fix this in commit fe090c34b724, so
PHASE_DEAD was used instead of PHASE_DISCONNECT to notify MM that the
port was disconnected, but that still early to ensure that the port
settings are restored.

The MM traces seen when the bug is triggered are:

ModemManager[2158]: <warn> (ttyACM1): could not re-acquire serial port lock: (5) Input/output error
ModemManager[2158]: <warn> Couldn't load Operator Code: 'Cannot run sequence: 'Could not open serial device ttyACM1: it has been forced close'

https://mail.gnome.org/archives/networkmanager-list/2019-June/msg00014.html

Author: Alfonso Sanchez-Beato
Author Date: 2020-06-24 16:13:41 UTC

tests: disable some non-working tests

There are some tests that do not run properly due to:

1. A bug in snapd that messes the mount namespace of NM:
https://bugs.launchpad.net/snapd/+bug/1884806
2. NM not reading configuration files created by netplan because those
lack a .nmconnection suffix. This is because the xenial version of
netplan does not add the suffix, while the more modern in focal does
add it.

2) happens because we run the focal NM on a system with xenial
base. 1) might be happening because of that too. We need to move to
test on UC20 and re-evaluate the situation. Unfortunately, that is not
easy as UC20 still lacks a way of customizing the images in a
reasonable way yet.

Author: Alfonso Sanchez-Beato
Author Date: 2020-05-14 16:53:53 UTC

Unblock autoconnect on new secrets

Enable autoconnect when the secrets are updated in case it was blocked
because of bad or no secrets.

Author: Alfonso Sanchez-Beato
Author Date: 2020-05-14 15:14:18 UTC

Unblock autoconnect on new secrets

Enable autoconnect when the secrets are updated in case it was blocked
because of bad or no secrets.

Author: Alfonso Sanchez-Beato
Author Date: 2020-05-13 09:32:35 UTC

Do not call scripts from the -phony part

In snapcraft 4.0, the downloaded debs are stored in the ~/.cached
folder instead of inside the porject parts folders. So we cannot run
some scripts that relied on those files being there. Probably we
should do this from CI instead.

Author: Alfonso Sanchez-Beato
Author Date: 2020-05-13 09:32:35 UTC

Do not call scripts from the -phony part

In snapcraft 4.0, the downloaded debs are stored in the ~/.cached
folder instead of inside the porject parts folders. So we cannot run
some scripts that relied on those files being there. Probably we
should do this from CI instead.

Author: Alfonso Sanchez-Beato
Author Date: 2020-04-06 10:34:21 UTC

Flush IPs trying to avoid naming dependencies

The names that netplan uses for connections might change, grep for
interface-name inside files instead. This also gives the ip command
more chances to succeed. Note that here we are not supporting using
MAC instead of interface name in netplan configuration.

Author: Alfonso Sanchez-Beato
Author Date: 2020-03-18 16:47:06 UTC

snap: update to newer NM deb package

Update to newer NM deb package and some minor clean-up of snapcraft.yaml.

Author: Alfonso Sanchez-Beato
Author Date: 2020-02-12 09:16:01 UTC

Find non-primed packages in an automated way

Author: Alfonso Sanchez-Beato
Author Date: 2020-02-07 13:13:05 UTC

Add libsqlite3-0 to unstage.txt

Make sure we remove libsqlite3-0 when releasing from CI from the list of
staged packages, as we are not including it anymore in the snap.

Author: Alfonso Sanchez-Beato
Author Date: 2020-02-03 18:07:16 UTC

Unstage some packages from networkmananger-phony

The networkmananger-phony part was staging as dependencies packages that
we were not actually including in the snap. Add to the list of packages
to unstage on release.

Author: Alfonso Sanchez-Beato
Author Date: 2019-09-12 08:13:02 UTC

Do not drop secrets even on failure of 4-way handshake

Author: System Enablement CI Bot
Author Date: 2019-09-10 11:49:10 UTC

Merge remote tracking branch add-changelog

Merge-Proposal: https://code.launchpad.net/~alfonsosanchezbeato/snappy-hwe-snaps/+git/network-manager/+merge/372525

Author: Alfonso Sanchez-Beato <alfonso.sanchez-beato@canonical.com>

snap: copy changelog to the package

Author: Alfonso Sanchez-Beato
Author Date: 2019-01-11 14:27:34 UTC

core: ignore IPv6 multicast in connection comparison

The default multicast route for IPv6 is set by default in some devices.
This makes comparisons between connections that should be the same to
fail, so they are not merged and unneeded connections appear in the
system. This commit make sure this does not happen. The route is
{ dest = "ff00::", prefix = 8 }. Fixes LP: #1811347.

Author: Alfonso Sanchez-Beato
Author Date: 2019-01-11 17:33:40 UTC

Some debug stuff

Author: Lennart Poettering
Author Date: 2018-10-19 10:12:33 UTC

dhcp6: make sure we have enough space for the DHCP6 option header

Fixes a vulnerability originally discovered by Felix Wilhelm from
Google.

CVE-2018-15688
LP: #1795921
https://bugzilla.redhat.com/show_bug.cgi?id=1639067

(cherry picked from commit 4dac5eaba4e419b29c97da38a8b1f82336c2c892)
(cherry picked from commit 01ca2053bbea09f35b958c8cc7631e15469acb79)
(cherry picked from commit fc230dca139142f409d7bac99dbfabe9b004e2fb)
(cherry picked from commit cc1e5a7f5731f223d1eb8473fa0eecbedfc0ae5f)
(cherry picked from commit c3221cb0c5b4a2936c198e33b6f7853141991277)
(cherry picked from commit f4f765534191ed3c5d8e78b97333f3fd978a2b63)
(cherry picked from commit 2a25872910606d83f0532d668e73ab4809ee7f90)
(cherry picked from commit ec471872e47f389d88a0dc6a12164feed378de39)

Author: Alfonso Sanchez-Beato
Author Date: 2018-10-31 09:23:08 UTC

Add snap setting to configure connectivity check

Three settings have been added:

* connectivity.uri
* connectivity.interval
* connectivity.response

Which correspond to to the configurations options for NetworkManager
with the same name (see "CONNECTIVITY SECTION" in NetworkManager.conf
man page). Bug associated to feature is LP: #1800048.

Author: Beniamino Galvani
Author Date: 2016-03-15 11:03:23 UTC

device: take care of default route of DHCP generated-assumed connections

In general we don't touch the externally set default route on devices
that use a generated-assumed connection. When the IP method is AUTO
(or DHCP), this means that we are not able to restore the default
route after a temporary expiration of the lease which removes
addresses/routes from the device.

Change this, and let NM update the default route for generated-assumed
devices using dynamic addressing.

https://bugzilla.redhat.com/show_bug.cgi?id=1265239
(cherry picked from commit 9b7f9af0776c5b741c616d3af4b0cda522c27295)

Author: Alfonso Sanchez-Beato
Author Date: 2018-09-12 10:21:49 UTC

Initialize properly variable in sd-ipv4acd.c

To avoid compiler warning.

Author: Alfonso Sanchez-Beato
Author Date: 2018-09-12 07:22:23 UTC

Compile wiht optimizations turned on

Override snapcraft's CFLAGS to make sure -O2 is set and -g is not
(LP: #1791333).

Author: Alfonso Sanchez-Beato
Author Date: 2018-09-07 11:00:07 UTC

tests: remove buggy test

This check fails because output of "snap list" changes continuously, so
you cannot rely on it. Also, the check is redundant.

Author: Alfonso Sanchez-Beato
Author Date: 2018-09-07 09:34:12 UTC

ipv4acd/ipv4ll: stop using read() on SOCK_DGRAM sockets

This applies systemd commit e095f51d to fix the same sort of issues
as those exposed in LP: #1790974.

Author: Alfonso Sanchez-Beato
Author Date: 2018-06-25 09:34:30 UTC

Change folder name dump -> snap-common

Author: Alfonso Sanchez-Beato
Author Date: 2018-06-07 15:09:07 UTC

Point build to my branch

Author: Alfonso Sanchez-Beato
Author Date: 2018-06-07 15:04:53 UTC

Debug info for lp: #1774954

Author: Alfonso Sanchez-Beato
Author Date: 2018-06-07 15:04:53 UTC

Debug info for lp: #1774954

Author: Alfonso Sanchez-Beato
Author Date: 2018-06-06 09:36:27 UTC

Include all libraries in the snap

So it is self-contained and does not depend on the core snap libraries.
Also, fix explicit mention of x86 arch that broke the build for other
architectures.

Author: Alfonso Sanchez-Beato
Author Date: 2018-05-30 16:06:19 UTC

Add explicitly some libraries to the snap

snapcraft was doing automatically this before, but the behavious has
apparently changed.

Author: Alfonso Sanchez-Beato
Author Date: 2018-01-30 08:32:29 UTC

Delay reconnect retries for modems

For modems it is better to wait a bit before re-trying to connect,
to give a chance for network conditions to change.

Author: Alfonso Sanchez-Beato
Author Date: 2018-03-06 07:39:50 UTC

Set GPL2+ license

Author: Alfonso Sanchez-Beato
Author Date: 2018-01-30 08:32:29 UTC

Delay reconnect retries for modems

For modems it is better to wait a bit before re-trying to connect,
to give a chance for network conditions to change.

Author: Alfonso Sanchez-Beato
Author Date: 2017-08-07 07:56:07 UTC

spread: core-support is not used anymore

Author: Alfonso Sanchez-Beato
Author Date: 2017-08-02 15:02:38 UTC

spread: wifi-connect-secured-ap: use utility function create_ap

So we avoid some pitfalls that were making this test fail some times.

Author: Alfonso Sanchez-Beato
Author Date: 2017-07-13 14:19:02 UTC

Address review comments

Author: Alfonso Sanchez-Beato
Author Date: 2017-04-25 08:54:18 UTC

Add test that checks interfaces on NM stop

Test that verifies that wifi interfaces are unconfigured when NM is
stopped in WoWLAN is not supported.

Author: Alfonso Sanchez-Beato
Author Date: 2017-03-30 13:01:48 UTC

Address review comments

Author: Alfonso Sanchez-Beato
Author Date: 2017-03-30 11:06:42 UTC

Fix suspend-resume test

Author: Alfonso Sanchez-Beato
Author Date: 2017-03-27 12:40:33 UTC

Remove assertion for empty DHCP6 options

It turns out that some routers return responses to Information-request
messages that do not contain any of the options that we insert in the
"options" table. When that happened and the info-only flag for DHCP6
was set, the assertion was triggered and NetworkManager crashed. We
remove the assertion as having empty options is a possibility and is
harmless anyway.

Author: Alfonso Sanchez-Beato
Author Date: 2017-03-06 13:56:27 UTC

Remove lldp tests from Makefile.am

This tests do not work in the CI environment.

Author: Alfonso Sanchez-Beato
Author Date: 2017-03-06 10:30:25 UTC

Add build script

Author: Beniamino Galvani
Author Date: 2016-10-26 10:06:39 UTC

wwan: fix wrong connection cast on device state change

nm_settings_connection_set_autoconnect_blocked_reason() must be called
on the settings-connection. Fixes the following:

GLib-GObject-WARNING **: invalid cast from 'NMSimpleConnection' to 'NMSettingsConnection'

Fixes: 06da3532428e3498c1e808ff8be1af48b540a6ff

Author: Alfonso Sanchez-Beato
Author Date: 2016-09-05 08:01:31 UTC

Ignore BLIP camera by using udev rules

Author: Alfonso Sanchez-Beato
Author Date: 2016-06-08 08:22:31 UTC

Add ppp plug to snap