Code review comment for lp://staging/~alexlauni/groundcontrol/bugfix-lp-520613

Revision history for this message
Alex Launi (alexlauni) wrote :

It should be pretty easy to modify gtkviews.py to make this type of thing
easier for other subclasses. I'll make some changes and resubmit.

On Feb 13, 2010 6:21 PM, "Martin Owens" <email address hidden> wrote:

Review: Needs Fixing
This looks like a brilliant fix and it teaches me some things about how list
view models work.

But I would like to see some of this logic make it's way into the
gtkviews.py so that it's available to other listing UIs such as project
listing and bug listing.

At the moment you've taken to removing the super calls and doing everything
in branches.py, I'd like to chat about what you found out from your research
into the problem to make sure that I don't make the same mistakes.

--
https://code.launchpad.net/~alexlauni/groundcontrol/bugfix-lp-520613/+merge/19276You
are the ow...

« Back to merge proposal