Code review comment for lp://staging/~alex-idereal/bzr-java-lib/fetch-xmloutput-during-build

  > 1) I am not sure if the shell scripts should handle changes in xmloutput
  > source code or not. Currently they cannot. I would expect the scripts to
  > check out a fresh copy of xmloutput on each run, however, the Linux one
  > performs the following check: [[ -d xmloutput ]] && exit. On the other
  > hand, the scripts will do their job for newly created branches and they can
  > be easily changed in the future if needed

I have updated it to check the version and replace if necessary,
I think this covers these two scenarios:

 + Development involves changes to xmloutput.
 + Standard version of xmloutput is fine.

For the DOS script we should probably change it to delete the
entire tree and export from launchpad each time. Could you
validate that script for me?

  > 2) The path in pom.xml requires a correction:
  > <executable>${basedir}/bin/${fetch-bazaar-plugins}</executable> should be:
  > <executable>${basedir}/scripts/${fetch-bazaar-plugins}</executable>

Fixed.

  > 3) Could you please consider changing the license to LGPL?

I updated it to GPL v2 or later to match the LICENSE file in bzr-java-lib.

Alex

--
idereal | deliver http://idereal.co.nz/
Get your software to market sooner 022 659 0282