Ubuntu One storage protocol

Merge lp://staging/~alecu/ubuntuone-storage-protocol/timestamp-autofix-2-0 into lp://staging/ubuntuone-storage-protocol/stable-2-0

  1. timestamp-autofix-2-0
  2. Merge into stable-2-0
Proposed by Alejandro J. Cura
Status: Merged
Approved by: Alejandro J. Cura
Approved revision: 142
Merged at revision: 141
Proposed branch: lp://staging/~alecu/ubuntuone-storage-protocol/timestamp-autofix-2-0
Merge into: lp://staging/ubuntuone-storage-protocol/stable-2-0
Diff against target: 335 lines (+243/-4)
3 files modified
tests/test_client.py (+143/-2)
ubuntuone/storageprotocol/client.py (+30/-2)
ubuntuone/storageprotocol/utils.py (+70/-0)
To merge this branch: bzr merge lp://staging/~alecu/ubuntuone-storage-protocol/timestamp-autofix-2-0
Reviewer Review Type Date Requested Status
John O'Brien (community) Approve
Diego Sarmentero (community) Approve
Review via email: mp+81792@code.staging.launchpad.net

Commit message

Do a HEAD request on the server to get accurate timestamp (LP: #692597)

Description of the change

Do a HEAD request on the server to get accurate timestamp (LP: #692597)

To post a comment you must log in.
lp://staging/~alecu/ubuntuone-storage-protocol/timestamp-autofix-2-0 updated
141. By Alejandro J. Cura

Use the dedicated time url

Revision history for this message
Diego Sarmentero (diegosarmentero) wrote :

Text conflict in tests/test_client.py
1 conflicts encountered.

Revision history for this message
Diego Sarmentero (diegosarmentero) wrote :

Forgot the need fixing in the comment above

review: Needs Fixing
Revision history for this message
Alejandro J. Cura (alecu) wrote :

Merged with stable branch, so the conflict should be solved now.

lp://staging/~alecu/ubuntuone-storage-protocol/timestamp-autofix-2-0 updated
142. By Alejandro J. Cura

merged with stable-2-0

Revision history for this message
Diego Sarmentero (diegosarmentero) wrote :

Looks great, all the tests were successful.

review: Approve
Revision history for this message
John O'Brien (jdobrien) wrote :

This looks good. Bonus points for the formatting fixes.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches