Code review comment for lp://staging/~alecu/ubuntuone-client/restrain-out-of-space-dialog

I'm not sure it's necessarily another bug entirely. Rather, after a little bit more thought, I think it is part of the fundamental flaw in the code that leads to this issue.

With 3000 files say, that would cauase the dialog to appear, instead of just show()ing the same dialog 3000 times, it is instead destroyed and then created again, over and over. This means it creates a state of constant flicker until the last display of the dialog, and the action happens fast enough that the user can't click "Cancel" in the middle. Destroying and creating the dialog so many times and so fast, consumes a lot of resources. While this isn't necessarily the primary fundamental flaw, I think it exposes another flaw. That is the code does not wait for all the events to coalesce, so that only one dialog is shown, at the end of the spam of messages from DBus.

While not necessarily a total fix, I do think it would be better than this patch, and be more of a step in the right direction for the total fix. And since the real target of this fix is an SRU for Maverick, I do think we need to exercise more caution in deciding what goes in, and try to minimize the change set before rushing it in.