Jockey

Merge lp://staging/~albertomilone/jockey/pkg-version into lp://staging/jockey

pkg-version
Merge into trunk

Proposed by Alberto Milone on 2010-04-11

Status:	Needs review
Proposed branch:	lp://staging/~albertomilone/jockey/pkg-version
Merge into:	lp://staging/jockey
Diff against target:	93 lines (+18/-1) 5 files modified jockey/backend.py (+1/-0) jockey/handlers.py (+9/-0) jockey/ui.py (+4/-1) tests/backend.py (+2/-0) tests/handlers.py (+2/-0)
To merge this branch:	bzr merge lp://staging/~albertomilone/jockey/pkg-version
Related bugs:	Link a bug report

Reviewer	Review Type	Date Requested	Status
Martin Pitt (community)		2010-04-11	Disapprove on 2010-04-12
Review via email: mp+23189@code.staging.launchpad.net

Description of the change

This branch adds initial support for retrieving the package version which, together with the code in pkg-version-ubuntu, allows us to fix LP: #543176

Revision history for this message

Martin Pitt (pitti) wrote on 2010-04-12:

Looks fine, please merge.

review: Approve

Revision history for this message

Martin Pitt (pitti) wrote on 2010-04-12:

Erm, wait a minute. A handler already has a "version" field. When I saw that patch, I thought we just forgot to export it, but we do. Why doesn't the nvidia driver just set this?

review: Needs Information

Revision history for this message

Martin Pitt (pitti) wrote on 2010-04-12:

Discussed on IRC. IMHO this will introduce duplicate structures into the core code which we won't ever get rid of again, and only for a corner case. Remember that you explicitly wanted to name the package "current", not "195"; so we should actually call it "current". Otherwise it'll create more confusion than it solves, since the package names in Jockey do not (always) reflect the package names in software-center etc.

If i18n is a concern, we have the ability to translate package descriptions, so maybe we should use that?

review: Disapprove

Revision history for this message

Alberto Milone (albertomilone) wrote on 2010-04-12:

A few things depend on the version field (in which we can find the driver flavour) already: the kernel module name, the package name and the recommended() method.

The package version doesn't necessarily match the driver flavour.