Unity System Compositor

Merge lp://staging/~alan-griffiths/unity-system-compositor/report-warnings-instead-of-crashing into lp://staging/unity-system-compositor

  1. report-warnings-instead-of-crashing
  2. Merge into trunk
Proposed by Alan Griffiths
Status: Merged
Approved by: kevin gunn
Approved revision: 274
Merged at revision: 274
Proposed branch: lp://staging/~alan-griffiths/unity-system-compositor/report-warnings-instead-of-crashing
Merge into: lp://staging/unity-system-compositor
Prerequisite: lp://staging/~alan-griffiths/unity-system-compositor/be-consistent-about-locking-MirScreen
Diff against target: 97 lines (+41/-7)
1 file modified
src/mir_screen.cpp (+41/-7)
To merge this branch: bzr merge lp://staging/~alan-griffiths/unity-system-compositor/report-warnings-instead-of-crashing
Reviewer Review Type Date Requested Status
Alexandros Frantzis (community) Approve
Andreas Pokorny (community) Approve
PS Jenkins bot (community) continuous-integration Approve
Review via email: mp+283975@code.staging.launchpad.net

Commit message

MirScreen makes calls to reconfigure Mir that can fail by throwing exceptions. Log these errors instead of crashing.

Description of the change

MirScreen makes calls to reconfigure Mir that can fail by throwing exceptions. Log these errors instead of crashing.

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:272
http://jenkins.qa.ubuntu.com/job/unity-system-compositor-ci/334/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-system-compositor-xenial-amd64-ci/35
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-system-compositor-xenial-armhf-ci/34
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-system-compositor-xenial-i386-ci/34

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/unity-system-compositor-ci/334/rebuild

review: Approve (continuous-integration)
lp://staging/~alan-griffiths/unity-system-compositor/report-warnings-instead-of-crashing updated
273. By Alan Griffiths

merge lp:unity-system-compositor

274. By Alan Griffiths

merge lp:~alan-griffiths/unity-system-compositor/be-consistent-about-locking-MirScreen/

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:274
http://jenkins.qa.ubuntu.com/job/unity-system-compositor-ci/339/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-system-compositor-xenial-amd64-ci/40
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-system-compositor-xenial-armhf-ci/39
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-system-compositor-xenial-i386-ci/39

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/unity-system-compositor-ci/339/rebuild

review: Approve (continuous-integration)
Revision history for this message
Andreas Pokorny (andreas-pokorny) wrote :

lgtm

review: Approve
Revision history for this message
Alexandros Frantzis (afrantzis) wrote :

OK.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches