Code review comment for lp://staging/~alan-griffiths/qtmir/untangle-libmirserver-from-QOBJECTs

Revision history for this message
Gerry Boland (gerboland) wrote :

May I propose this patch to neaten up the CMakeLists.txt file considerably:
http://pastebin.ubuntu.com/24312831/

=== modified file 'src/platforms/mirserver/screensmodel.h'
+ namespace graphics {
+ namespace detail { struct GraphicsConfCardIdTag; struct GraphicsConfOutputIdTag; }
+ typedef IntWrapper <detail::GraphicsConfCardIdTag> DisplayConfigurationCardId;
+ typedef IntWrapper <detail::GraphicsConfOutputIdTag> DisplayConfigurationOutputId;
+ class Display;
+ class DisplayConfigurationOutput;
+ }
I'm not keen on duplicating Mir code like this, looks very fragile. Is this temporary? I do intend to update the poorly named ScreensModel to use miral::ActiveDisplayObserver stuff.

Rest is good, glad to see we're going in the same direction.

review: Needs Fixing

« Back to merge proposal