QtMir

Merge lp://staging/~alan-griffiths/qtmir/small-refactoring-of-QtEventFeeder into lp://staging/qtmir

  1. small-refactoring-of-QtEventFeeder
  2. Merge into trunk
Proposed by Alan Griffiths
Status: Work in progress
Proposed branch: lp://staging/~alan-griffiths/qtmir/small-refactoring-of-QtEventFeeder
Merge into: lp://staging/qtmir
Diff against target: 111 lines (+16/-22)
2 files modified
src/platforms/mirserver/qteventfeeder.cpp (+13/-19)
src/platforms/mirserver/qteventfeeder.h (+3/-3)
To merge this branch: bzr merge lp://staging/~alan-griffiths/qtmir/small-refactoring-of-QtEventFeeder
Reviewer Review Type Date Requested Status
Michał Sawicz Needs Fixing
Daniel d'Andrada (community) Approve
PS Jenkins bot (community) continuous-integration Approve
Review via email: mp+266381@code.staging.launchpad.net

Commit message

Put the timestamp acquisition in QtEventFeeder::dispatch() instead of repeating it four times in the type-specific dispatch functions.

Description of the change

Put the timestamp acquisition in QtEventFeeder::dispatch() instead of repeating it four times in the type-specific dispatch functions.

(Should obviously not change behaviour.)

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:352
http://jenkins.qa.ubuntu.com/job/qtmir-ci/332/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/qtmir-wily-amd64-ci/65
    SUCCESS: http://jenkins.qa.ubuntu.com/job/qtmir-wily-armhf-ci/65
        deb: http://jenkins.qa.ubuntu.com/job/qtmir-wily-armhf-ci/65/artifact/work/output/*zip*/output.zip

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/qtmir-ci/332/rebuild

review: Approve (continuous-integration)
Reply
Revision history for this message
Daniel d'Andrada (dandrader) wrote :

Code looks good.

review: Approve (codewise)
Reply
lp://staging/~alan-griffiths/qtmir/small-refactoring-of-QtEventFeeder updated
350. By Alan Griffiths

  Deduplicate timestamp acquisition

351. By Alan Griffiths

  Make timestamps consistently ulong

352. By Alan Griffiths

  Inline single use variable

Revision history for this message
Daniel d'Andrada (dandrader) wrote :

Manual tests didn't show any regressions.

review: Approve
Reply
Revision history for this message
Michał Sawicz (saviq) wrote :

Text conflict in src/platforms/mirserver/qteventfeeder.cpp
1 conflicts encountered.

review: Needs Fixing
Reply

Unmerged revisions

352. By Alan Griffiths

  Inline single use variable

351. By Alan Griffiths

  Make timestamps consistently ulong

350. By Alan Griffiths

  Deduplicate timestamp acquisition

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches