Merge lp://staging/~alan-griffiths/qtmir/small-refactoring-of-MirWindowManager into lp://staging/qtmir

PASSED: Continuous integration, rev:351
http://jenkins.qa.ubuntu.com/job/qtmir-ci/335/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/qtmir-wily-amd64-ci/68
    SUCCESS: http://jenkins.qa.ubuntu.com/job/qtmir-wily-armhf-ci/68
        deb: http://jenkins.qa.ubuntu.com/job/qtmir-wily-armhf-ci/68/artifact/work/output/*zip*/output.zip

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/qtmir-ci/335/rebuild

PASSED: Continuous integration, rev:352
http://jenkins.qa.ubuntu.com/job/qtmir-ci/336/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/qtmir-wily-amd64-ci/69
    SUCCESS: http://jenkins.qa.ubuntu.com/job/qtmir-wily-armhf-ci/69
        deb: http://jenkins.qa.ubuntu.com/job/qtmir-wily-armhf-ci/69/artifact/work/output/*zip*/output.zip

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/qtmir-ci/336/rebuild

+auto MirWindowManagerImpl::add_surface(
am not a fan of using "auto" unless the type is completely unmistakeably obvious. Here I can't quite deduce, is it a bool to say surface was added successfully? Or a shared/unique pointer to that new surface? Or a list of surfaces?

The C++ committee and I don't agree on some things just yet ;)

+auto MirWindowManager::create() -> std::unique_ptr<MirWindowManager>
For consistency I'd prefer you avoid this new C++ syntax. Few are comfortable with it at the moment IMO.

Are those the only reasons for using C++14?

I'm open to a good argument saying why it'll be good to use, but the only reason I can really see for using auto in function definitions is if we'd like to use duck-typing in C++, which isn't necessary here IMO.

> +auto MirWindowManagerImpl::add_surface(
> am not a fan of using "auto" unless the type is completely unmistakeably
> obvious. Here I can't quite deduce, is it a bool to say surface was added
> successfully? Or a shared/unique pointer to that new surface? Or a list of
> surfaces?
>
> The C++ committee and I don't agree on some things just yet ;)
>
> +auto MirWindowManager::create() -> std::unique_ptr<MirWindowManager>
> For consistency I'd prefer you avoid this new C++ syntax. Few are comfortable
> with it at the moment IMO.
>
> Are those the only reasons for using C++14?

No, those are all C++11. The use of C++14 is:

+ return std::make_unique<MirWindowManagerImpl>(displayLayout);

> +auto MirWindowManagerImpl::add_surface(
> am not a fan of using "auto" unless the type is completely unmistakeably
> obvious. Here I can't quite deduce, is it a bool to say surface was added
> successfully? Or a shared/unique pointer to that new surface? Or a list of
> surfaces?

FWIW That's preexisting - see line 98

FAILED: Continuous integration, rev:354
http://jenkins.qa.ubuntu.com/job/qtmir-ci/396/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/qtmir-wily-amd64-ci/129/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/qtmir-wily-armhf-ci/129/console

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/qtmir-ci/396/rebuild

FAILED: Continuous integration, rev:355
http://jenkins.qa.ubuntu.com/job/qtmir-ci/399/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/qtmir-wily-amd64-ci/132/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/qtmir-wily-armhf-ci/132/console

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/qtmir-ci/399/rebuild

The following packages have unmet dependencies:
 udev : Depends: libudev1 (= 225-1ubuntu1) but 225-1ubuntu2 is to be installed.

+ static auto create(
+ mir::shell::FocusController* focus_controller,
+ const std::shared_ptr<mir::shell::DisplayLayout> &displayLayout)
+ -> std::unique_ptr<MirWindowManager>;
We still have one new-fangled definition here.

> + static auto create(
> + mir::shell::FocusController* focus_controller,
> + const std::shared_ptr<mir::shell::DisplayLayout> &displayLayout)
> + -> std::unique_ptr<MirWindowManager>;
> We still have one new-fangled definition here.

that's a declaration. :^)

FAILED: Continuous integration, rev:356
http://jenkins.qa.ubuntu.com/job/qtmir-ci/408/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/qtmir-wily-amd64-ci/141/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/qtmir-wily-armhf-ci/141/console

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/qtmir-ci/408/rebuild

Gerry happy :)

PASSED: Continuous integration, rev:358
http://jenkins.qa.ubuntu.com/job/qtmir-ci/445/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/qtmir-vivid-amd64-ci/141
    SUCCESS: http://jenkins.qa.ubuntu.com/job/qtmir-vivid-armhf-ci/141
        deb: http://jenkins.qa.ubuntu.com/job/qtmir-vivid-armhf-ci/141/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/qtmir-vivid-i386-ci/23
    SUCCESS: http://jenkins.qa.ubuntu.com/job/qtmir-wily-amd64-ci/178
    SUCCESS: http://jenkins.qa.ubuntu.com/job/qtmir-wily-armhf-ci/178
        deb: http://jenkins.qa.ubuntu.com/job/qtmir-wily-armhf-ci/178/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/qtmir-wily-i386-ci/23

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/qtmir-ci/445/rebuild

LGTM