Code review comment for lp://staging/~akretion-team/openobject-server/openobject-server_5.0_patches

Hello,

I'm sorry, but why the hell the commit is a normal pig commit and not a
regular clean MERGE?????
Is that the the way you are improving the codebase?
Is there any good reason why it's not a fucking merge?

Let me explain better, this is how it look right now:
suppose I have OpenERP running in production for critical applications,
so I might track the 5.0 branch whenever I want to update the code/fix the
bugs.

Currently, If I look at rev #1866.1.3, all I see is a huge patch that seems
risk with almost no explanation.
So I would think: hey Tiny is not serious, those guys are just committing
large experimental change on claimed stable releases.
Furthermore, with the commit message, you associate my name to such a mess.
I'm sorry, this is exaclty the same story as here
http://www.openobject.com/forum/viewtopic.php?p=46328
repeating over and over. Guys, I'm sorry about that, but for successful
OpenERP we all need more professionalism.

Instead, if you did a clean merge, the enlighten user tracking 5.0 branch
that would tomorrow be your community basis
could instead know the history of the commits, were does this comes from
(trunk and would have been better even on trunk to merge original branches
from Almacom or Activity Solutions (sorry can't remember who did it
initially) properly). The enlighten user could also look here, find out
that this was not yet a risky
large random codebase change because this time it has been done in a branch
and tested for at least a week by several people. Should he have a question
he would get in touch with those people.

So please, unless there is a really good reason, re-do the merge properly in
the history and try to improve in the future, this is more important as what
you might think. Who was wondering 3 years ago those mistakes
http://www.openobject.com/forum/viewtopic.php?p=46328 would lag the project
for so long?
Trying to raise funds? You know what, you'll have experts tracking your
fucking codebase and the more pig it looks, the cheaper you'll sell it. Not
a good strategy.

Sorry for the rant, but I spent time getting this right, so I expect you
behave more professionally to show you do like community contributions.

Regards,

Raphaël Valyi

On Wed, Nov 4, 2009 at 4:35 AM, hda (OpenERP) <email address hidden> wrote:

> Review: Approve
> Hello Raphaël Valyi,
>
> Your patch has been merged on stable and dukai's problem has been fixed
> too.
> replace whole tree,form.. tag will work now.
> please test it once again and send feedback hare.
>
> Thanks for contribution.
> HDA.
> --
>
> https://code.launchpad.net/~akretion-team/openobject-server/openobject-server_5.0_patches/+merge/14112
> You proposed
> lp:~akretion-team/openobject-server/openobject-server_5.0_patches for
> merging.
>