Code review comment for lp://staging/~akretion-team/openobject-server/openobject-server_5.0_patches

Hello, no error on my side too, using it since some 5 days now.
Still, dukai, reported an error with this view: http://pastie.org/681248
I'll test that in a few hours.

About xml.dom, no idea.
BUT, I can tell you that using last Ubuntu Karmic this is not an issue.
So I don't know if xml.dom is deprecated or not, but at least it causes no
trouble on recent Ubuntu's/other Linux distros.

Regards,

Raphaël

On Tue, Nov 3, 2009 at 11:31 AM, hda (OpenERP) <email address hidden> wrote:

> The patch seems working,
> I have been using is since 3 days and didn't get any error yet.
> But it is not completely remove xml.dom dependency.
> It is still exist in
> server/bin/pychart/svgcanvas.py
> server/bin/report/pyPdf/xmp.py
> server/bin/report/render/simple.py
> server/bin/report/custom.py
> server/bin/tools/translate.py
>
> The reason behind this is
> from xml.dom import getDOMImplementation
>
> I think we don't have similar functionality in etree for
> getDOMImplementation.
>
> Can anybody suggest some way to completely remove xml.dom dependency?
> any pychart is third party tool so we have to wait for them to remove xml
> dependency.
>
> --
>
> https://code.launchpad.net/~akretion-team/openobject-server/openobject-server_5.0_patches/+merge/14112
> You proposed
> lp:~akretion-team/openobject-server/openobject-server_5.0_patches for
> merging.
>