Code review comment for lp://staging/~akretion-team/openobject-server/openobject-server_5.0_patches

Revision history for this message
Husen Daudi (husendaudi) wrote :

The patch seems working,
I have been using is since 3 days and didn't get any error yet.
But it is not completely remove xml.dom dependency.
It is still exist in
server/bin/pychart/svgcanvas.py
server/bin/report/pyPdf/xmp.py
server/bin/report/render/simple.py
server/bin/report/custom.py
server/bin/tools/translate.py

The reason behind this is
from xml.dom import getDOMImplementation

I think we don't have similar functionality in etree for getDOMImplementation.

Can anybody suggest some way to completely remove xml.dom dependency?
any pychart is third party tool so we have to wait for them to remove xml dependency.

« Back to merge proposal