Code review comment for lp://staging/~akretion-team/openobject-server/openobject-server_5.0_patches
Revision history for this message
| Joël Grand-Guillaume @ camptocamp (jgrandguillaume-c2c) wrote | # |
review:
Approve
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
2eb648a
demo site
(Get the code!)
Hello,
I just tested it into a replication of a production instance and it seems that everything is ok with this one. As people said, the lack of unit test starts to hurts, but for now, we have to deal with that...
I suggest to merge that branch even if we should avoid those kind of merge into stable branch, but here, the need is to big to let it only for the next versions...
So, for me, it's ok to merge that into stable release.
My2Cents,
Joël
P.S. We are working on a test bot for functional part here at Camptocamp. This will not be unit test, but more process test. Like : create an invoice, validate it and see the result is ok with tax amount, or try to get all partner, etc... I'll hope to post something soon to have some feed-back on it.