Code review comment for lp://staging/~akretion-team/openobject-server/openobject-server_5.0_patches

Revision history for this message
Raphaƫl Valyi - http://www.akretion.com (rvalyi) wrote :

All right,

I'm happy with this position, I urge all serious community members to test
it on their end, to ensure, wa have no Regression. At Akretion, we are
already two testing it fulltime for our regular projects, if something is
wrong with the patch, we will find out in time.

On Thu, Oct 29, 2009 at 12:18 PM, Fabien (Open ERP) <email address hidden> wrote:

> Review: Approve
> I don't have time to test the patch, I let the quality team do this work.
> But, following the discussion, I think we should merge the proposed patch.
> Keeping an old library may leads to more troubles.
>
> The automated tests from test.openobject.com will test a lot of things
> (all fields_view_get methods are tested at each commit). I would suggest the
> quality team to launch the automated tests from the base_module_quality
> tests on all official module. If it passes manual check and automated tests,
> you should merge.
> --
>
> https://code.launchpad.net/~akretion-team/openobject-server/openobject-server_5.0_patches/+merge/14112
> You proposed
> lp:~akretion-team/openobject-server/openobject-server_5.0_patches for
> merging.
>

« Back to merge proposal