Code review comment for lp://staging/~akretion-team/openobject-server/openobject-server_5.0_patches

Hello Christophe,

I agree that the change is not small. But don't you agree it's testable?
Frankly using it since yesterday no issue at all. I think some of us could
confirm it safe and after that only we merge it. What I think is that this
is worth the effort, just saying fuck once more to all Ubuntu users for the
next say 6 months will by no means help the product popularity...

I insist, this is not like the report rewrite situation. No logic is changed
here, it's just about swapping a lib for an other. All changes code lines
are easily tested, available here, why not make the effort to give it a test
and then merge it eventually?

My 0.02cts

On Thu, Oct 29, 2009 at 6:28 AM, Christophe Chauvet - http://www.syleam.fr/
<email address hidden> wrote:

> Review: Disapprove
> Hi
>
> I desagree with this, The 5.0 stable must only received bugfix, and this
> issue is not a bug.
> I consider the stable version of the server, must be run on the stable
> version of Debian (actual Lenny) and Ubuntu (Actuel Hardy (8.04 LTS)).
>
> Otherwise if GTK client doesn't work with Karmic, then yes we must correct
> the issue.
>
> 5.2 must be freeze in December, and RC available (March/April) for the
> Ubuntu latest stable (10.04 LTS)
>
> Regards,
>
>
> --
>
> https://code.launchpad.net/~akretion-team/openobject-server/openobject-server_5.0_patches/+merge/14112
> You proposed
> lp:~akretion-team/openobject-server/openobject-server_5.0_patches for
> merging.
>