Code review comment for lp://staging/~akretion-team/openobject-server/openobject-server_5.0_patches

Revision history for this message
Raphaƫl Valyi - http://www.akretion.com (rvalyi) wrote :

Backport from trunk to 5-0 lxml + etree standard Python XML libs instead of deprecated xpatch and dom which are not maintained anymore and hence cause a lots of headache to install OpenERP 5-0 branch on Ubuntu distros for instance. Now, OpenERP 5-0 wouldn't even run on new Ubuntu Karmic because no more port of the deprecated packages seems to exist.

In any case, the fix is clean and easy to test. I tested it extensively, I ask partners/community members to do the same. Then it's safe to merge it, it involve limited piece of code for which it's easy to find test cases (use demo data + manufacturing profile + translation for instance). I've been especially cautious with the merges/conflicts and tests. You can trust me at least more than the guys from Tiny who didn't even resolved conflicts properly when merging that old_trunk back into new trunk branch...
We did it carefully. This can be tested.

SO PLEASE, TEST AND TEST AGAIN, BUT PLEASE DO MERGE IT IN 5-0 TO SAVE USERS FROM INSTALLATION HEADHACHES, YOU WILL ALSO AVOID ALL UBUNTU USERS COMING TO THE FORUM AND ASKING WHY THE HELL IT WON'T INSTALL OR BEING DOOMED TO USE OLDER BUGGY VERSIONS OF OPENERP. YOU'LL ALSO AVOID DEBIAN/UBUNTU MAINTAINERS THAT ARE NOT OPENERP SPECIALISTS AT ALL TO MAINTAIN THEMSELVES UGLY PATCHES WHEN THEY HAVE TIME WHICH WILL HARDLY MATCH STABLE RELEASES OF OPENERP.

Thanks in advance

« Back to merge proposal