Merge lp://staging/~akopytov/percona-server/RDBA-bug1081016-5.1 into lp://staging/percona-server/5.1

Proposed by Alexey Kopytov
Status: Merged
Approved by: Alexey Kopytov
Approved revision: no longer in the source branch.
Merged at revision: 549
Proposed branch: lp://staging/~akopytov/percona-server/RDBA-bug1081016-5.1
Merge into: lp://staging/percona-server/5.1
Diff against target: 302 lines (+196/-22)
4 files modified
Percona-Server/client/mysqldump.c (+121/-21)
Percona-Server/configure.in (+1/-1)
Percona-Server/mysql-test/r/percona_mysqldump_innodb_optimize_keys.result (+47/-0)
Percona-Server/mysql-test/t/percona_mysqldump_innodb_optimize_keys.test (+27/-0)
To merge this branch: bzr merge lp://staging/~akopytov/percona-server/RDBA-bug1081016-5.1
Reviewer Review Type Date Requested Status
Alexey Kopytov (community) Needs Fixing
Stewart Smith (community) Approve
Review via email: mp+154350@code.staging.launchpad.net

Description of the change

  Bug #1081016: mysqldump --innodb-optimize-keys may produce invalid SQL
                with explicitly named FK constraints

  The problem was that mysqldump --innodb-optimize-keys produced invalid
  SQL for cases when there was an explicitly named FK constrained which
  implied a implicit secondary index with the same name. An attempt to
  skip such a key definition from table schema and add it later with an
  ALTER TABLE statement resulted in an "Incorrect index name" error,
  because an index with the same name has already been created implicitly.

  Fixed by detecting such cases in skip_secondary_keys() and restoring
  the secondary to table schema in case there's an explicitly named FK
  constraint with the same name.

http://jenkins.percona.com/view/PS%205.1/job/percona-server-5.1-param/528/

To post a comment you must log in.
Revision history for this message
Stewart Smith (stewart) :
review: Approve
Revision history for this message
Alexey Kopytov (akopytov) wrote :

Wrong merge from the (originally prerequisite) branch for bug #989253. It should not remove the "ALTER TABLE `t1` ADD KEY `c` (`c`);" line from the .result file.

review: Needs Fixing
Revision history for this message
Alexey Kopytov (akopytov) wrote :

Fixed.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches