Code review comment for lp://staging/~ahayzen/ubuntu-printing-app/page-range-validate-and-count

Revision history for this message
Michael Sheldon (michael-sheldon) wrote :

Page ranges shouldn't be sorted, as the user may have a valid reason for wanting to specify their pages in a different order (e.g. "1, 5, 3" should print in that order), this is the current behaviour for existing print dialogs.

Also it'd be nice to support reversed ranges, so "5-1" would print 5, 4, 3, 2, 1 in that order. Or a more complicated example could be "3-1, 5, 4" should print 3, 2, 1, 5, 4.

review: Needs Fixing

« Back to merge proposal