Ubuntu Music App

Merge lp://staging/~ahayzen/music-app/show-toolbar-on-play into lp://staging/music-app/trusty

  1. show-toolbar-on-play
  2. Merge into trusty
Proposed by Andrew Hayzen
Status: Merged
Approved by: Victor Thompson
Approved revision: 177
Merged at revision: 176
Proposed branch: lp://staging/~ahayzen/music-app/show-toolbar-on-play
Merge into: lp://staging/music-app/trusty
Diff against target: 41 lines (+6/-0)
2 files modified
MusicStart.qml (+2/-0)
music-app.qml (+4/-0)
To merge this branch: bzr merge lp://staging/~ahayzen/music-app/show-toolbar-on-play
Reviewer Review Type Date Requested Status
Victor Thompson Approve
Ubuntu Phone Apps Jenkins Bot continuous-integration Approve
Review via email: mp+190809@code.staging.launchpad.net

Commit message

* Show toolbar when a track is clicked

Description of the change

* Show toolbar when a track is clicked

To post a comment you must log in.
Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :

PASSED: Continuous integration, rev:176
http://91.189.93.70:8080/job/music-app-ci/175/
Executed test runs:
    SUCCESS: http://91.189.93.70:8080/job/generic-mediumtests/932
    SUCCESS: http://91.189.93.70:8080/job/music-app-precise-amd64-ci/175
    SUCCESS: http://91.189.93.70:8080/job/music-app-quantal-amd64-ci/175
    SUCCESS: http://91.189.93.70:8080/job/music-app-raring-amd64-ci/175
    SUCCESS: http://91.189.93.70:8080/job/music-app-saucy-amd64-ci/177

Click here to trigger a rebuild:
http://91.189.93.70:8080/job/music-app-ci/175/rebuild

review: Approve (continuous-integration)
Revision history for this message
Victor Thompson (vthompson) wrote :

Good idea. There are more places we make the now playing view visible. I think we should also popup the toolbar in those cases as well.

review: Needs Fixing
Revision history for this message
Andrew Hayzen (ahayzen) wrote :

Such as?

And this branch is just fixing the bug Lisette reported.

Any other places that aren't in the design spec should probably be done in a separate branch as they will need to be discussed with design.

Revision history for this message
Victor Thompson (vthompson) wrote :

The Recently Played and Genres lists need to be fixed so this is consistent.

Revision history for this message
Andrew Hayzen (ahayzen) wrote :

Ah ok, forgot they don't use trackClicked()

lp://staging/~ahayzen/music-app/show-toolbar-on-play updated
177. By Andrew Hayzen

* Fix for selecting Recently Played or Genre

Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :

PASSED: Continuous integration, rev:177
http://91.189.93.70:8080/job/music-app-ci/180/
Executed test runs:
    SUCCESS: http://91.189.93.70:8080/job/generic-mediumtests/937
    SUCCESS: http://91.189.93.70:8080/job/music-app-precise-amd64-ci/180
    SUCCESS: http://91.189.93.70:8080/job/music-app-quantal-amd64-ci/180
    SUCCESS: http://91.189.93.70:8080/job/music-app-raring-amd64-ci/180
    SUCCESS: http://91.189.93.70:8080/job/music-app-saucy-amd64-ci/182

Click here to trigger a rebuild:
http://91.189.93.70:8080/job/music-app-ci/180/rebuild

review: Approve (continuous-integration)
Revision history for this message
Victor Thompson (vthompson) wrote :

Looks good.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to status/vote changes: