Juju Charms Collection
apache2 package

Code review comment for lp://staging/~ahasenack/charms/precise/apache2/apache2-default-servername

  1. Precise Pangolin (12.04)
  2. apache2-default-servername
  3. Merge into trunk
Revision history for this message
Marco Ceppi (marcoceppi) wrote :

I thinks this is a bit too specific for a change in config_get for charm-helpers. However, I think having a "default" key for when config-get returns either None or possibly an empty key might be useful. Either way this change LGTM. I'll merge it in and let you decided if you want to amend charm-helpers with that functionality.

review: Approve

« Back to merge proposal