Merge lp://staging/~adeuring/launchpad/bug-746866 into lp://staging/launchpad

Proposed by Abel Deuring
Status: Merged
Approved by: Aaron Bentley
Approved revision: no longer in the source branch.
Merged at revision: 12975
Proposed branch: lp://staging/~adeuring/launchpad/bug-746866
Merge into: lp://staging/launchpad
Diff against target: 29 lines (+5/-3)
1 file modified
lib/lp/bugs/model/bugbranch.py (+5/-3)
To merge this branch: bzr merge lp://staging/~adeuring/launchpad/bug-746866
Reviewer Review Type Date Requested Status
Aaron Bentley (community) Approve
Review via email: mp+59954@code.staging.launchpad.net

Commit message

[r=abentley][bug=746866] more efficient visibility query for BugBranchSet.getBranchesWithVisibleBugs()

Description of the change

This branch fixes bug 746866: Person:+branches timeout: sometimes-slow bug-branch link query.

Robert already analyzed the problem and suggested two fixes; I took the one from comment #4 in the bug report.

test: ./bin/test bugs -vvt test_bugbranch

no lint

To post a comment you must log in.
Revision history for this message
Aaron Bentley (abentley) wrote :

This looks good. On line 30, I think the original spacing "where=subscribed" is correct.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.