Merge lp://staging/~adeuring/launchpad/bug-588276 into lp://staging/launchpad
Status: | Merged |
---|---|
Approved by: | Graham Binns |
Approved revision: | no longer in the source branch. |
Merged at revision: | 11018 |
Proposed branch: | lp://staging/~adeuring/launchpad/bug-588276 |
Merge into: | lp://staging/launchpad |
Diff against target: |
524 lines (+343/-11) 9 files modified
lib/lp/bugs/browser/bugtarget.py (+45/-1) lib/lp/bugs/browser/tests/test_bugtarget_configure.py (+5/-1) lib/lp/bugs/browser/tests/test_bugtarget_filebug.py (+264/-0) lib/lp/bugs/stories/guided-filebug/xx-bug-reporting-guidelines.txt (+18/-2) lib/lp/registry/browser/distribution.py (+2/-1) lib/lp/registry/browser/distributionsourcepackage.py (+1/-0) lib/lp/registry/browser/project.py (+3/-2) lib/lp/registry/browser/tests/distribution-views.txt (+4/-3) lib/lp/registry/browser/tests/distributionsourcepackage-views.txt (+1/-1) |
To merge this branch: | bzr merge lp://staging/~adeuring/launchpad/bug-588276 |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Graham Binns (community) | code | Approve | |
Review via email: mp+27606@code.staging.launchpad.net |
Description of the change
This branch fixes bug 588276: "Enable use of bug_reported_
It adds the field bug_reported_
The property bug_reported_
This acquisition logic is fine, but it ignores the case that a customized message is defined for a project group but not for a project within the project group, or for a distribution but not for DistributionSou
Hence I duplicated/
tests:
bin/test -t test_bugtarget_
bin/test -t xx-bug-
no lint
> + "bug_reported_ acknowledgement ", widget( 'bugtracker' , ProductBugTrack erWidget) ledgementMessag e(self. context) ] related= security_ related, private=private, bug_reported_ acknowledgement = "Thank you for your bug report." entMessage( self, context):
> ]
> custom_
>
> @@ -443,7 +446,7 @@
> else:
> private = False
>
> - notifications = ["Thank you for your bug report."]
> + notifications = [self.getAcknow
> params = CreateBugParams(
> title=title, comment=comment, owner=self.user,
> security_
> @@ -775,6 +778,47 @@
> })
> return guidelines
>
> + default_
> +
> + def getAcknowledgem
> + """An acknowlegement message displayed to the user."""
> + # If a given context has not a custom message, we go up in the
Minor grammatical nit pick: "does not have a" reads better than "has not a".