charmworld

Code review comment for lp://staging/~adeuring/charmworld/1206659-simpler-es-mapping

  1. 1206659-simpler-es-mapping
  2. Merge into trunk
Revision history for this message
Curtis Hovey (sinzui) wrote :

Hi Able.

I think our intent is to treat charm_text_index, charm_integer_index as constants. Can you capitalise these identifiers and change them from lists to tuples (to ensure nothing can mutate them)?

Please place an XXX in front of the comment on line 230 because we intend to fix this issue soon.

I think this is good to land.

review: Approve (code)

« Back to merge proposal