I saw this in my email and thought I should comment.
import's should not be on the same line according to pep8 http://legacy.python.org/dev/peps/pep-0008/#imports, it's also good practice to keep them in alphabetical order.
13 +import os, subprocess 14 +import shutil, logging 15 import tempfile
should be:
import logging import os import shutil import subprocess import tempfile
if you apt-get install python-flake8 you can run 'flake8 some_file.py' and it will tell you about the pep8 style guides problems in your code.
A lot of code editors have a flake8 plugin that will tell you when you have errors, so you don't have to do it manually.
« Back to merge proposal
I saw this in my email and thought I should comment.
import's should not be on the same line according to pep8 http:// legacy. python. org/dev/ peps/pep- 0008/#imports, it's also good practice to keep them in alphabetical order.
13 +import os, subprocess
14 +import shutil, logging
15 import tempfile
should be:
import logging
import os
import shutil
import subprocess
import tempfile
if you apt-get install python-flake8 you can run 'flake8 some_file.py' and it will tell you about the pep8 style guides problems in your code.
A lot of code editors have a flake8 plugin that will tell you when you have errors, so you don't have to do it manually.