Code review comment for lp://staging/~abreu-alexandre/webbrowser-app/intent

Revision history for this message
Alexandre Abreu (abreu-alexandre) wrote :

> 307 + trimUriSeparator(path);
>
> Is this correct? A valid URI path normally starts with a leading forward
> slash, so why trim it? And a path that ends with a slash is (I think)
> different from a path that doesn’t. E.g.:
>
> http://example.com/test/?q=r
>
> !=
>
> http://example.com/test?q=r

I want things to be somewhat normalized (if I can call it this way), for the
web and *in practice* I dont think it makes a difference (unless I miss an
obvious case).

After thinking about it, I think you are right on this, rather be strict ...

« Back to merge proposal