Code review comment for lp://staging/~abreu-alexandre/webbrowser-app/intent

Revision history for this message
Alexandre Abreu (abreu-alexandre) wrote :

> In IntentFilter::isValidIntentFilterResult(…), the checks expect the result to
> have a host, but in the declaration of the IntentUriDescription struct, 'host'
> is marked optional. So, is it optional or required?

optional as you known and as I know ..., but as I said before
I wanted the object sent to the js have a strict & fixed structure,

I can remove if you strongly object,

« Back to merge proposal