Code review comment for lp://staging/~abreu-alexandre/webbrowser-app/intent

Revision history for this message
Alexandre Abreu (abreu-alexandre) wrote :

> 279 + // Fallback to a noop
> 280 + result = d->evaluate(
> 281 +
> IntentFilterPrivate::DEFAULT_PASS_THROUGH_FILTER
> 282 + , intentDescription).toVariant().toMap();
>
> This looks like a rather complex (and expensive) way of transforming
> intentDescription into a QVariantMap.
> What about getting rid of the IntentUriDescription struct altogether, to
> replace it everywhere with QVariantMap?

The 'expensive' factor is very relative to the usage context ... but in this
case it not that, ... it has nothing to do w/ intentDescription, but w/ the result
of QJSValue -> QVAriantMap ...

« Back to merge proposal