Code review comment for lp://staging/~abreu-alexandre/webbrowser-app/intent

Revision history for this message
Olivier Tilloy (osomon) wrote :

In tests/unittests/intent-filter/CMakeLists.txt:

838 +set(TEST tst_IntentFilterTests)
839 +set(SOURCES
840 + ${CMAKE_SOURCE_DIR}/src/app/webcontainer/intent-filter.cpp

  this should be ${webapp-container_SOURCE_DIR}/intent-filter.cpp

841 + tst_IntentFilterTests.cpp
842 +)
843 +set(WEBAPP_CONTAINER_INTENT_FILTER webapp-container-intent-filter)

  the variable defined here seems unused

844 +include_directories(${CMAKE_SOURCE_DIR})

  this should be ${webapp-container_SOURCE_DIR}

845 +add_executable(${TEST} ${SOURCES})
846 +qt5_use_modules(${TEST} Core Test Qml)
847 +add_test(${TEST} ${CMAKE_CURRENT_BINARY_DIR}/${TEST} -xunitxml -o ${TEST}.xml)

review: Needs Fixing

« Back to merge proposal