Code review comment for lp://staging/~abreu-alexandre/webbrowser-app/intent

Revision history for this message
Alexandre Abreu (abreu-alexandre) wrote :

> 676 + def get_intent_filtered_uri(self, uri):
> […]
> 681 + webviewContainer.slots.handleIntentUri(uri)
>
> This is wrong, the test case shouldn’t call a slot on the QML object: this is
> not testing a real-world use-case any longer. Instead, the webapp’s homepage
> should have an "intent://" link and the test should click that link and ensure
> that as a result the URL of the webview changes to the expected transformed
> URL.

I know that this is "wrong", but I did it this way after exploring how
'intrumentable' the url-dispatcher was. And it is not at the required
level to test the whole flow ...

The way that it is it test *some* of the logic and bits of code (closer
to something at the unit level),

« Back to merge proposal