Code review comment for lp://staging/~abreu-alexandre/webbrowser-app/intent

Revision history for this message
Olivier Tilloy (osomon) wrote :

676 + def get_intent_filtered_uri(self, uri):
[…]
681 + webviewContainer.slots.handleIntentUri(uri)

This is wrong, the test case shouldn’t call a slot on the QML object: this is not testing a real-world use-case any longer. Instead, the webapp’s homepage should have an "intent://" link and the test should click that link and ensure that as a result the URL of the webview changes to the expected transformed URL.

review: Needs Fixing

« Back to merge proposal