Code review comment for lp://staging/~abreu-alexandre/webapps-core/ebay

Revision history for this message
David Barth (dbarth) wrote :

The mobile ebay website still works great on a krillin, ie regular phone.
The mobile ebay website just frowns at mobile webviews running on a larger
screen, like a tablet.

This is more about setting a different UA depending on the screen used by
the app, ie:
- phone screen or side-stage window : mobile UA
- tablet screen or desktop window : desktop UA

Those combinations should be configurable, because there will of course be
websites that differ.

Those options would also solve the Gmail keyboard hide'n seek problem.

On Wed, Aug 17, 2016 at 5:00 PM, Alexandre Abreu <
<email address hidden>> wrote:

> Alexandre Abreu has proposed merging lp:~abreu-alexandre/webapps-core/ebay
> into lp:webapps-core.
>
> Commit message:
> Fix ebay target website & fw
>
> Requested reviews:
> Ubuntu Phablet Team (phablet-team)
> Related bugs:
> Bug #1575780 in The Webapps-core project: "Ebay webapp doesn't display
> on frieza just displays an error"
> https://bugs.launchpad.net/webapps-core/+bug/1575780
>
> For more details, see:
> https://code.launchpad.net/~abreu-alexandre/webapps-core/
> ebay/+merge/303148
>
> Fix ebay target website & fw
> --
> You are subscribed to branch lp:webapps-core.
>
> === modified file 'webapp-ebay/manifest.json'
> --- webapp-ebay/manifest.json 2016-05-03 19:08:43 +0000
> +++ webapp-ebay/manifest.json 2016-08-17 15:00:01 +0000
> @@ -1,6 +1,6 @@
> {
> "description": "eBay (webapp version)",
> - "framework": "ubuntu-sdk-14.10",
> + "framework": "ubuntu-sdk-15.04",
> "architecture": "all",
> "hooks": {
> "webapp-ebay": {
> @@ -11,6 +11,6 @@
> "maintainer": "Webapps Team <email address hidden>",
> "name": "com.ubuntu.developer.webapps.webapp-ebay",
> "title": "webapp-ebay",
> - "version": "1.0.15"
> + "version": "1.1"
> }
>
>
> === modified file 'webapp-ebay/webapp-ebay.desktop'
> --- webapp-ebay/webapp-ebay.desktop 2016-01-16 20:59:17 +0000
> +++ webapp-ebay/webapp-ebay.desktop 2016-08-17 15:00:01 +0000
> @@ -1,7 +1,7 @@
> [Desktop Entry]
> Type=Application
> Terminal=false
> -Exec=webapp-container --enable-back-forward --webappUrlPatterns=https?://*
> .ebay.com/*,http?://*.ebaydesc.com/* http://m.ebay.com/ %u
> +Exec=webapp-container --enable-back-forward --webappUrlPatterns=https?://*
> .ebay.com/*,http?://*.ebaydesc.com/* https://www.ebay.com/ %u
> Name=eBay
> Icon=./ebay.png
> X-Ubuntu-Touch=true
>
> === modified file 'webapp-ebay/webapp-ebay.json'
> --- webapp-ebay/webapp-ebay.json 2016-05-03 19:08:43 +0000
> +++ webapp-ebay/webapp-ebay.json 2016-08-17 15:00:01 +0000
> @@ -8,5 +8,5 @@
> "content_exchange",
> "content_exchange_source"
> ],
> - "policy_version": 1.2
> + "policy_version": 1.3
> }
>
>
>

« Back to merge proposal