Code review comment for lp://staging/~abreu-alexandre/unity-webapps-qml/fail-safe-content-hub-bindings

Revision history for this message
Alexandre Abreu (abreu-alexandre) wrote :

> I don't think that you need to import the QtQuick 2.0 module.

I didn't initially, but it seems to be required to known about QtObject,

> Also, I'm not sure if the exception will always be thrown, or if it's possible
> for Qt.createQmlObject() to return null without raising the exception; if so,
> you should check for its return value != null as well.

+1

> But I'm not sure of either points, so if you have already tested this and this
> is the correct solution, +1 from me.

« Back to merge proposal