Merge lp://staging/~abreu-alexandre/oxide/donottrack into lp://staging/~oxide-developers/oxide/oxide.trunk
Proposed by
Alexandre Abreu
Status: | Merged | ||||
---|---|---|---|---|---|
Merged at revision: | 1159 | ||||
Proposed branch: | lp://staging/~abreu-alexandre/oxide/donottrack | ||||
Merge into: | lp://staging/~oxide-developers/oxide/oxide.trunk | ||||
Diff against target: |
438 lines (+212/-1) (has conflicts) 13 files modified
qt/core/browser/oxide_qt_web_context.cc (+24/-0) qt/core/browser/oxide_qt_web_context.h (+3/-0) qt/core/glue/oxide_qt_web_context_proxy.h (+3/-0) qt/quick/api/oxideqquickwebcontext.cc (+19/-0) qt/quick/api/oxideqquickwebcontext_p.h (+6/-0) qt/tests/qmltests/api/tst_WebContext_doNotTrack.py (+18/-0) qt/tests/qmltests/api/tst_WebContext_doNotTrack.qml (+74/-0) shared/browser/oxide_browser_context.cc (+33/-1) shared/browser/oxide_browser_context.h (+5/-0) shared/browser/oxide_browser_context_observer.h (+2/-0) shared/browser/oxide_network_delegate.cc (+10/-0) shared/browser/oxide_web_view_contents_helper.cc (+14/-0) shared/browser/oxide_web_view_contents_helper.h (+1/-0) Text conflict in qt/core/browser/oxide_qt_web_context.cc |
||||
To merge this branch: | bzr merge lp://staging/~abreu-alexandre/oxide/donottrack | ||||
Related bugs: |
|
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Chris Coulson | Approve | ||
Review via email: mp+261766@code.staging.launchpad.net |
Commit message
Handle do not track
Description of the change
Handle do not track
To post a comment you must log in.
Thanks, I've left some comments inline.
Also, the test is missing a few bits:
- It should verify that the default is off. navigator. doNotTrack if you change the setting without reloading the page? Does it update automatically? If it does, then that should be tested.
- It should check that the notify signal is emitted when you toggle it.
- What happens to window.