Code review comment for lp://staging/~abentley/launchpad/bmp-iprivacy

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

= Summary =
Implement IPrivacy for BranchMergeProposal

== Proposed fix ==
Privacy for branch merge proposals is determined by the involved
branches: the source, target and optional dependent branch. If any are
private, the merge proposal is private.

== Pre-implementation notes ==
Pre-implementation was with thumper

== Implementation details ==
I also added a test that BranchMergeProposal implements
IBranchMergeProposal, as a drive-by.

== Tests ==
bin/test test_branchmergeproposals -t Privacy

== Demo and Q/A ==
Create a private branch. Propose it for merging. Note that the merge
proposal has the standard privacy bars.

= Launchpad lint =

Checking for conflicts. and issues in doctests and templates.
Running jslint, xmllint, pyflakes, and pylint.
Using normal rules.

Linting changed files:
  lib/lp/code/configure.zcml
  lib/lp/code/interfaces/branchmergeproposal.py
  lib/lp/code/model/branchmergeproposal.py
  lib/lp/code/model/tests/test_branchmergeproposals.py

== Pylint notices ==

lib/lp/code/interfaces/branchmergeproposal.py
    27: [F0401] Unable to import 'lazr.lifecycle.event' (No module named
lifecycle)
    42: [F0401] Unable to import 'lazr.restful.fields' (No module named
restful)
    43: [F0401] Unable to import 'lazr.restful.declarations' (No module
named restful)
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iEYEARECAAYFAkqnyGgACgkQ0F+nu1YWqI2mIACaAv9Y1uhElpNOOFhOgoiT/aFY
V0gAn24bUSNXGGRCZxoWzYoL0VBhDHjM
=T23r
-----END PGP SIGNATURE-----