Code review comment for lp://staging/~abentley/launchpad/abort-failed-vote

Revision history for this message
Celso Providelo (cprov) wrote :

Aaron,

We discussed your approach for being explicit about the validation, instead of validating any not-None messsage passed in. You convinced me that there is no reason to block internal callsites to pass not-None messages and skip validation if that's what they need to do.

We rely on the fact that external callsites should not mess with the 'private' argument.

Please add 'validate_message' to the lib/lp/services/mail/sendmail.py __all__ and r=me.

review: Approve

« Back to merge proposal