QtMir

Merge lp://staging/~aacid/qtmir/dont_reuse_stale_cookies into lp://staging/qtmir

  1. dont_reuse_stale_cookies
  2. Merge into trunk
Proposed by Albert Astals Cid
Status: Merged
Approved by: Gerry Boland
Approved revision: 626
Merged at revision: 637
Proposed branch: lp://staging/~aacid/qtmir/dont_reuse_stale_cookies
Merge into: lp://staging/qtmir
Diff against target: 12 lines (+2/-0)
1 file modified
src/platforms/mirserver/eventbuilder.cpp (+2/-0)
To merge this branch: bzr merge lp://staging/~aacid/qtmir/dont_reuse_stale_cookies
Reviewer Review Type Date Requested Status
Andreas Pokorny (community) Approve
Gerry Boland (community) Approve
Review via email: mp+321426@code.staging.launchpad.net

Commit message

EventInfo::store: Store an empty cookie for mir events without cookie

Otherwise when the m_eventInfoVector ringbuffer wraps we end up returning a stale cookie for events that had no cookie (e.g. mouse move events)

Description of the change

 * Are there any related MPs required for this MP to build/function as expected?
No

 * Did you perform an exploratory manual test run of your code change and any related functionality?
Yes

 * If you changed the packaging (debian), did you subscribe the ubuntu-unity team to this MP?
N/A

To post a comment you must log in.
Revision history for this message
Gerry Boland (gerboland) wrote :

Yes, makes sense.

review: Approve
Revision history for this message
Andreas Pokorny (andreas-pokorny) wrote :

oh yes..

mea culpa.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches