Merge lp://staging/~aacid/qtmir/bringBackR538 into lp://staging/qtmir

Proposed by Albert Astals Cid
Status: Work in progress
Proposed branch: lp://staging/~aacid/qtmir/bringBackR538
Merge into: lp://staging/qtmir
Diff against target: 14 lines (+1/-2)
1 file modified
src/modules/Unity/Application/application_manager.cpp (+1/-2)
To merge this branch: bzr merge lp://staging/~aacid/qtmir/bringBackR538
Reviewer Review Type Date Requested Status
Gerry Boland (community) Approve
Unity8 CI Bot (community) continuous-integration Approve
Review via email: mp+307308@code.staging.launchpad.net

Commit message

Bring back r538

It seems we may have a workaround in unity8 so that way we get the speed benefit of this change

Description of the change

 * Are there any related MPs required for this MP to build/function as expected?
https://code.launchpad.net/~mterry/unity8/greeter-keep-alive-emergency/+merge/304101

 * Did you perform an exploratory manual test run of your code change and any related functionality?
Not yet, will do with silo

 * If you changed the packaging (debian), did you subscribe the ubuntu-unity team to this MP?
N/A

To post a comment you must log in.
Revision history for this message
Unity8 CI Bot (unity8-ci-bot) wrote :

PASSED: Continuous integration, rev:566
https://unity8-jenkins.ubuntu.com/job/lp-qtmir-ci/389/
Executed test runs:
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build/3023
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-0-fetch/3051
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=vivid+overlay/2908
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=vivid+overlay/2908/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=xenial+overlay/2908
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=xenial+overlay/2908/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=yakkety/2908
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=yakkety/2908/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=vivid+overlay/2908
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=vivid+overlay/2908/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=xenial+overlay/2908
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=xenial+overlay/2908/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=yakkety/2908
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=yakkety/2908/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=vivid+overlay/2908
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=vivid+overlay/2908/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=xenial+overlay/2908
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=xenial+overlay/2908/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=yakkety/2908
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=yakkety/2908/artifact/output/*zip*/output.zip

Click here to trigger a rebuild:
https://unity8-jenkins.ubuntu.com/job/lp-qtmir-ci/389/rebuild

review: Approve (continuous-integration)
Revision history for this message
Gerry Boland (gerboland) wrote :

If it is indeed worked around, then great. The crash this caused was deep in Qt, I hope you're right!

review: Approve
Revision history for this message
Albert Astals Cid (aacid) wrote :

Note the depending MR is not ready yet.

Revision history for this message
Albert Astals Cid (aacid) wrote :

I'll put this to Work in Progress to clear the "accepted" queue since it seems that the prerequisite branch is not being worked on for the moment.

Unmerged revisions

566. By Albert Astals Cid

Bring back r538

It seems we may have a workaround in unity8 so that way we get the speed benefit of this change

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches