Unity

Code review comment for lp://staging/~3v1n0/unity/indicators-p

  1. indicators-p
  2. Merge into trunk
Revision history for this message
Michal Hruby (mhr3) wrote :

183 data->proxy = proxy_;

Makes me sad that it doesn't use the dbus proxy class from unity core.

194 + g_idle_add_full (G_PRIORITY_DEFAULT, (GSourceFunc) send_show_entry, data, NULL);

Moreover this is pretty dangerous, it should at least grab a ref on the proxy. Alternatively such timeouts should be removed in the destructor.

1114 +#include <fcntl.h>

I hope this isn't needed?

« Back to merge proposal