Code review comment for lp://staging/~3v1n0/libappindicator/vala-bindings-fixes

Revision history for this message
Marco Trevisan (TreviƱo) (3v1n0) wrote :

Thanks, I didn't test to build it in another builddir, I've fixed the issue using a workaround (basically vapigen needs a *.metadata file to be in the same directory of the *.gir file, and building it in a separate dir caused it not to be imported, using *.in files and copying them works as expected), plus I've added proper gtk3 support...
Is this fine?

review: Needs Resubmitting

« Back to merge proposal