Code review comment for lp://staging/~3v1n0/gtk/unity-border-radius-support
Revision history for this message
| Marco Trevisan (Treviño) (3v1n0) wrote | # |
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
2eb648a
demo site
(Get the code!)
> One comment in general: do we really need to query the title widget to find
> out the borders that will be drawn on the toplevel? Something seems wrong
> here. I would have expected that we can query this information directly from
> the window itself in some way (and avoid the ugly hacks about assuming zeros).
Not as far I know... The window itself has not rounded corners, but it can have a titlebox which has rounded corners.
By defining a border-radius to the window itself, gives no rounded corners by default. It might be something that will work in the future, though. But not right now AFAIK.
To remove the workaround we could get these values from the toplevel, and in case a titlebox is defined we get them from that, but we can't query them from the toplevel, from what I see.