lp://staging/~desrt/indicator-appmenu/hud-rewrite-wip

Branch merges

Propose for merging

No branches dependent on this one.

Merged into lp://staging/indicator-appmenu/0.4

Charles Kerr (community): Approve on 2012-03-27

Diff: 493 lines (+106/-28)

12 files modified

src/hudappindicatorsource.c (+28/-2)
src/huddbusmenucollector.c (+37/-5)
src/huddbusmenucollector.h (+5/-1)
src/huddebugsource.c (+1/-1)
src/hudindicatorsource.c (+1/-0)
src/huditem.c (+10/-4)
src/huditem.h (+2/-0)
src/hudmenumodelcollector.c (+9/-4)
src/hudmenumodelcollector.h (+2/-1)
src/hudquery.c (+0/-8)
src/hudwindowsource.c (+7/-2)
tools-vala/hud-gtk.vala (+4/-0)

api

Related source package recipes

No recipes using this branch. (?)

Create packaging recipe

Related snap packages

Related bugs

Bug #921231: XUL Applications don't show up in HUD	High	Fix Released
Bug #950079: HUD: GMenuModel: Doesn't highlight hits	High	Fix Released
Bug #950080: HUD: GMenuModel: Doesn't write to usage database	High	Fix Released
Bug #950402: hud-service crashed with SIGSEGV in g_type_check_instance()	High	Fix Released
Bug #953579: hud-service crashed with SIGSEGV in hud_string_list_get_tail()	High	Fix Released
Bug #953620: hud-service crashed with SIGSEGV in g_str_equal()	Medium	Fix Released
Bug #953771: hud-service crashed with SIGSEGV in hud_dbusmenu_collector_property_changed()	Medium	Fix Released
Bug #955937: hud-service crashed with SIGABRT in g_assertion_message()	Medium	Fix Released

Link a bug report

Related blueprints

242. By desrt on 2012-03-26

hud: don't send duplicate OPENED events on property changes

241. By desrt on 2012-03-26

hud-gtk: close query if we have the empty string

240. By desrt on 2012-03-23

Remove some old XXX comments that no longer apply

239. By desrt on 2012-03-23

Add back the icons

238. By desrt on 2012-03-17

hud-service: dbusmenu collector: hold a reference on the root menu item

In the root-changed case, the DbusmenuClient drops the reference on the
root item before alerting us that it has changed. We then go iterating
over our own (now-dead) copy of that item in order to remove it from our
internal hashtable.

Keep our own reference to it to ensure that this is safe.

This could explain lp:955937.

237. By desrt on 2012-03-16

hud-service: delay dropping of query by 1 second

Unity sends a 'CloseQuery' followed immediately by a 'StartQuery' on
each keystroke in the search field. This results in a bunch of extra
dbusmenu messages being sent as the use count drops briefly to 0 only to
go immediately back to 1.

We can prevent that by delaying the destruction of the query.

This decreases the number of dbus messages resulting from a short search
by a factor of about 4 (on a number that measures in the 100s).

236. By desrt on 2012-03-16

add hud-gtk to the build system

This introduces a mandatory build-time dependency on Vala 0.15 and gtk3 (both needed for GtkApplication).

235. By desrt on 2012-03-16

hud-service: add some debug output to the dbus front-end (to help debug unity issues)

234. By desrt on 2012-03-16

merge trunk

233. By desrt on 2012-03-16

hud-service: indicatorsource: on indicator disappearance *unuse* the dbusmenu instead of using it extra

Probably this has absolutely zero impact since the source is going to be
destroyed one line later anyway, but it reads really badly (and strictly
speaking, the menus should be closed if they've been opened).