Merge lp://staging/~desrt/indicator-appmenu/hud-rewrite-wip into lp://staging/indicator-appmenu/0.4

Proposed by desrt
Status: Merged
Approved by: Charles Kerr
Approved revision: 242
Merge reported by: Charles Kerr
Merged at revision: not available
Proposed branch: lp://staging/~desrt/indicator-appmenu/hud-rewrite-wip
Merge into: lp://staging/indicator-appmenu/0.4
Diff against target: 493 lines (+106/-28)
12 files modified
src/hudappindicatorsource.c (+28/-2)
src/huddbusmenucollector.c (+37/-5)
src/huddbusmenucollector.h (+5/-1)
src/huddebugsource.c (+1/-1)
src/hudindicatorsource.c (+1/-0)
src/huditem.c (+10/-4)
src/huditem.h (+2/-0)
src/hudmenumodelcollector.c (+9/-4)
src/hudmenumodelcollector.h (+2/-1)
src/hudquery.c (+0/-8)
src/hudwindowsource.c (+7/-2)
tools-vala/hud-gtk.vala (+4/-0)
To merge this branch: bzr merge lp://staging/~desrt/indicator-appmenu/hud-rewrite-wip
Reviewer Review Type Date Requested Status
Charles Kerr (community) Approve
Review via email: mp+99046@code.staging.launchpad.net

Description of the change

add back support for icons

also, remove some comments that no longer apply

To post a comment you must log in.
241. By desrt

hud-gtk: close query if we have the empty string

242. By desrt

hud: don't send duplicate OPENED events on property changes

Revision history for this message
Charles Kerr (charlesk) wrote :

Looks good.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches