Merge lp://staging/~zyga/lava-core/fix-prep-venv into lp://staging/lava-core
Status: | Rejected |
---|---|
Rejected by: | Zygmunt Krynicki |
Proposed branch: | lp://staging/~zyga/lava-core/fix-prep-venv |
Merge into: | lp://staging/lava-core |
Prerequisite: | lp://staging/~zyga/lava-core/lava-tool-merge |
Diff against target: |
43 lines (+11/-6) 1 file modified
prep-venv (+11/-6) |
To merge this branch: | bzr merge lp://staging/~zyga/lava-core/fix-prep-venv |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Zygmunt Krynicki (community) | Disapprove | ||
Michael Hudson-Doyle (community) | Approve | ||
Review via email: mp+102345@code.staging.launchpad.net |
Description of the change
Fix a oversight in prep-venv that would make in not install certain packages
Unmerged revisions
- 22. By Zygmunt Krynicki
-
Fix prep-venv to install packages that are already installed in the host
It seems that pip --environment= is broken and ignores no-site-packages flag of
the virtual environment. This had a negative effect of not installing packages
that are available on the host, outside of the virtual environment. To work
around that we explicity activate the virtual environment and not pass
--environment to pip. - 21. By Zygmunt Krynicki
-
Document why we use lava-tool-%s prefix in KeyringAuthBackend
- 20. By Zygmunt Krynicki
-
Update docscrings to refer to the `lava` command
- 19. By Zygmunt Krynicki
-
Update copyright lines to reference lava-core
This is a fully automatic replacement. I also added myself to Author: in a few
files I made more changes. - 18. By Zygmunt Krynicki
-
Fix import broken by auth_add -> auth add change
- 17. By Zygmunt Krynicki
-
Update prep-venv with lava-tool dependencies
I've added argparse and keyring for lava-tool runtime dependencies and
unittest2, mocker (in a new section) for test dependencies. - 16. By Zygmunt Krynicki
-
Change lava-tool auth-add to lava auth add
I've added a new command group 'auth' with the old auth-add command (renamed to
'add'). I also removed the old lava-tool console script as I intend to keep it
in the transitional package (lava-tool) - 15. By Zygmunt Krynicki
-
Use unittest2.collector to discover test code
This will allow us to drop manual test registration classes and hase a good
upgrade path for python3 - 14. By Zygmunt Krynicki
-
Remove the old lava_tool package.
This package only contains the legacy imports that pull in lava.tool code. I
plan on leaving this in lava-tool transitional package later on. - 13. By Zygmunt Krynicki
-
Update Dispatcher.run() docstring
Ugh. Did you file this as a bug on pip?