Merge lp://staging/~zyga/checkbox/new-validation into lp://staging/checkbox

Proposed by Zygmunt Krynicki
Status: Work in progress
Proposed branch: lp://staging/~zyga/checkbox/new-validation
Merge into: lp://staging/checkbox
Diff against target: 233 lines (+69/-39)
2 files modified
plainbox/plainbox/provider_manager.py (+7/-1)
plainbox/plainbox/test_provider_manager.py (+62/-38)
To merge this branch: bzr merge lp://staging/~zyga/checkbox/new-validation
Reviewer Review Type Date Requested Status
Maciej Kisielewski (community) Approve
Review via email: mp+238187@code.staging.launchpad.net

Description of the change

29e3be4 plainbox:provider_manager: modernize tests
ec204d2 plainbox:provider_manager: make new validation default

To post a comment you must log in.
Revision history for this message
Maciej Kisielewski (kissiel) wrote :

Looks good!
+1

review: Approve
Revision history for this message
Daniel Manrique (roadmr) wrote :
Download full text (11.4 KiB)

The attempt to merge lp:~zkrynicki/checkbox/new-validation into lp:checkbox failed. Below is the output from the failed tests.

[precise] starting container
[precise] (timing) 0.06user 0.01system 0:04.18elapsed 1%CPU (0avgtext+0avgdata 7868maxresident)k
[precise] (timing) 0inputs+32outputs (0major+5763minor)pagefaults 0swaps
[precise] provisioning container
[precise] (timing) 37.19user 9.95system 1:25.57elapsed 55%CPU (0avgtext+0avgdata 51496maxresident)k
[precise] (timing) 0inputs+16408outputs (0major+4445725minor)pagefaults 0swaps
[precise-testing] Starting tests...
Found a test script: ./checkbox-gui/requirements/container-tests-checkbox-gui-build
[precise-testing] container-tests-checkbox-gui-build: PASS
[precise-testing] (timing) 32.08user 2.20system 0:34.77elapsed 98%CPU (0avgtext+0avgdata 116392maxresident)k
[precise-testing] (timing) 0inputs+4240outputs (0major+478224minor)pagefaults 0swaps
Found a test script: ./checkbox-ng/requirements/container-tests-checkbox-ng-unit
[precise-testing] container-tests-checkbox-ng-unit: PASS
[precise-testing] (timing) 0.49user 0.13system 0:00.64elapsed 96%CPU (0avgtext+0avgdata 39688maxresident)k
[precise-testing] (timing) 0inputs+3336outputs (0major+20368minor)pagefaults 0swaps
Found a test script: ./checkbox-support/requirements/container-tests-checkbox-support
[precise-testing] container-tests-checkbox-support: PASS
[precise-testing] (timing) 14.65user 0.12system 0:14.92elapsed 99%CPU (0avgtext+0avgdata 82836maxresident)k
[precise-testing] (timing) 0inputs+1032outputs (0major+31054minor)pagefaults 0swaps
Found a test script: ./checkbox-touch/requirements/container-tests-touch-unit-tests
[precise-testing] container-tests-touch-unit-tests: PASS
[precise-testing] (timing) 0.00user 0.01system 0:00.02elapsed 57%CPU (0avgtext+0avgdata 2016maxresident)k
[precise-testing] (timing) 0inputs+8outputs (0major+2346minor)pagefaults 0swaps
Found a test script: ./plainbox/plainbox/impl/providers/categories/requirements/container-tests-provider-categories
[precise-testing] container-tests-provider-categories: PASS
[precise-testing] (timing) 0.16user 0.02system 0:00.20elapsed 92%CPU (0avgtext+0avgdata 13376maxresident)k
[precise-testing] (timing) 0inputs+176outputs (0major+5842minor)pagefaults 0swaps
Found a test script: ./plainbox/requirements/001-container-tests-plainbox-egg-info
[precise-testing] 001-container-tests-plainbox-egg-info: PASS
[precise-testing] (timing) 0.14user 0.02system 0:00.18elapsed 90%CPU (0avgtext+0avgdata 10496maxresident)k
[precise-testing] (timing) 0inputs+88outputs (0major+4983minor)pagefaults 0swaps
Found a test script: ./plainbox/requirements/container-tests-plainbox
[precise-testing] container-tests-plainbox: PASS
[precise-testing] (timing) 11.71user 0.82system 0:12.73elapsed 98%CPU (0avgtext+0avgdata 63932maxresident)k
[precise-testing] (timing) 0inputs+2584outputs (0major+107090minor)pagefaults 0swaps
Found a test script: ./plainbox/requirements/container-tests-plainbox-documentation
[precise-testing] container-tests-plainbox-documentation: PASS
[precise-testing] (timing) 2...

Revision history for this message
Daniel Manrique (roadmr) wrote :
Download full text (11.4 KiB)

The attempt to merge lp:~zkrynicki/checkbox/new-validation into lp:checkbox failed. Below is the output from the failed tests.

[precise] starting container
[precise] (timing) 0.06user 0.01system 0:04.19elapsed 1%CPU (0avgtext+0avgdata 7864maxresident)k
[precise] (timing) 0inputs+32outputs (0major+5774minor)pagefaults 0swaps
[precise] provisioning container
[precise] (timing) 37.97user 10.15system 1:28.45elapsed 54%CPU (0avgtext+0avgdata 51504maxresident)k
[precise] (timing) 0inputs+16408outputs (0major+4462442minor)pagefaults 0swaps
[precise-testing] Starting tests...
Found a test script: ./checkbox-gui/requirements/container-tests-checkbox-gui-build
[precise-testing] container-tests-checkbox-gui-build: PASS
[precise-testing] (timing) 30.82user 2.20system 0:33.65elapsed 98%CPU (0avgtext+0avgdata 116392maxresident)k
[precise-testing] (timing) 0inputs+4224outputs (0major+478225minor)pagefaults 0swaps
Found a test script: ./checkbox-ng/requirements/container-tests-checkbox-ng-unit
[precise-testing] container-tests-checkbox-ng-unit: PASS
[precise-testing] (timing) 0.52user 0.12system 0:00.66elapsed 96%CPU (0avgtext+0avgdata 39680maxresident)k
[precise-testing] (timing) 0inputs+3336outputs (0major+20357minor)pagefaults 0swaps
Found a test script: ./checkbox-support/requirements/container-tests-checkbox-support
[precise-testing] container-tests-checkbox-support: PASS
[precise-testing] (timing) 14.45user 0.16system 0:16.26elapsed 89%CPU (0avgtext+0avgdata 82812maxresident)k
[precise-testing] (timing) 0inputs+1032outputs (0major+31162minor)pagefaults 0swaps
Found a test script: ./checkbox-touch/requirements/container-tests-touch-unit-tests
[precise-testing] container-tests-touch-unit-tests: PASS
[precise-testing] (timing) 0.00user 0.00system 0:00.02elapsed 44%CPU (0avgtext+0avgdata 2016maxresident)k
[precise-testing] (timing) 0inputs+8outputs (0major+2337minor)pagefaults 0swaps
Found a test script: ./plainbox/plainbox/impl/providers/categories/requirements/container-tests-provider-categories
[precise-testing] container-tests-provider-categories: PASS
[precise-testing] (timing) 0.17user 0.03system 0:00.22elapsed 92%CPU (0avgtext+0avgdata 13380maxresident)k
[precise-testing] (timing) 0inputs+176outputs (0major+5840minor)pagefaults 0swaps
Found a test script: ./plainbox/requirements/001-container-tests-plainbox-egg-info
[precise-testing] 001-container-tests-plainbox-egg-info: PASS
[precise-testing] (timing) 0.14user 0.06system 0:00.22elapsed 91%CPU (0avgtext+0avgdata 10496maxresident)k
[precise-testing] (timing) 0inputs+88outputs (0major+4983minor)pagefaults 0swaps
Found a test script: ./plainbox/requirements/container-tests-plainbox
[precise-testing] container-tests-plainbox: PASS
[precise-testing] (timing) 12.05user 0.76system 0:13.17elapsed 97%CPU (0avgtext+0avgdata 63960maxresident)k
[precise-testing] (timing) 0inputs+2584outputs (0major+107004minor)pagefaults 0swaps
Found a test script: ./plainbox/requirements/container-tests-plainbox-documentation
[precise-testing] container-tests-plainbox-documentation: PASS
[precise-testing] (timing) ...

Revision history for this message
Zygmunt Krynicki (zyga) wrote :

I'll try to land it again, I wonder if the earlier failures were all caused by the bug we found and fixed recently (stale whitelists)

Revision history for this message
Daniel Manrique (roadmr) wrote :
Download full text (11.4 KiB)

The attempt to merge lp:~zkrynicki/checkbox/new-validation into lp:checkbox failed. Below is the output from the failed tests.

[precise] starting container
[precise] (timing) 0.05user 0.02system 0:04.20elapsed 1%CPU (0avgtext+0avgdata 7864maxresident)k
[precise] (timing) 0inputs+32outputs (0major+5766minor)pagefaults 0swaps
[precise] provisioning container
[precise] (timing) 36.85user 11.81system 1:31.57elapsed 53%CPU (0avgtext+0avgdata 51516maxresident)k
[precise] (timing) 0inputs+16424outputs (0major+4443526minor)pagefaults 0swaps
[precise-testing] Starting tests...
Found a test script: ./checkbox-gui/requirements/container-tests-checkbox-gui-build
[precise-testing] container-tests-checkbox-gui-build: PASS
[precise-testing] (timing) 30.01user 2.30system 0:32.70elapsed 98%CPU (0avgtext+0avgdata 116392maxresident)k
[precise-testing] (timing) 0inputs+4240outputs (0major+478219minor)pagefaults 0swaps
Found a test script: ./checkbox-ng/requirements/container-tests-checkbox-ng-unit
[precise-testing] container-tests-checkbox-ng-unit: PASS
[precise-testing] (timing) 0.64user 0.14system 0:00.82elapsed 96%CPU (0avgtext+0avgdata 39684maxresident)k
[precise-testing] (timing) 0inputs+3352outputs (0major+20390minor)pagefaults 0swaps
Found a test script: ./checkbox-support/requirements/container-tests-checkbox-support
[precise-testing] container-tests-checkbox-support: PASS
[precise-testing] (timing) 15.56user 0.19system 0:15.85elapsed 99%CPU (0avgtext+0avgdata 83216maxresident)k
[precise-testing] (timing) 0inputs+1032outputs (0major+31368minor)pagefaults 0swaps
Found a test script: ./checkbox-touch/requirements/container-tests-touch-unit-tests
[precise-testing] container-tests-touch-unit-tests: PASS
[precise-testing] (timing) 0.00user 0.00system 0:00.02elapsed 36%CPU (0avgtext+0avgdata 2020maxresident)k
[precise-testing] (timing) 0inputs+8outputs (0major+2339minor)pagefaults 0swaps
Found a test script: ./plainbox/plainbox/impl/providers/categories/requirements/container-tests-provider-categories
[precise-testing] container-tests-provider-categories: PASS
[precise-testing] (timing) 0.21user 0.04system 0:00.27elapsed 93%CPU (0avgtext+0avgdata 13376maxresident)k
[precise-testing] (timing) 0inputs+176outputs (0major+5834minor)pagefaults 0swaps
Found a test script: ./plainbox/requirements/001-container-tests-plainbox-egg-info
[precise-testing] 001-container-tests-plainbox-egg-info: PASS
[precise-testing] (timing) 0.16user 0.02system 0:00.21elapsed 91%CPU (0avgtext+0avgdata 10504maxresident)k
[precise-testing] (timing) 0inputs+88outputs (0major+4986minor)pagefaults 0swaps
Found a test script: ./plainbox/requirements/container-tests-plainbox
[precise-testing] container-tests-plainbox: PASS
[precise-testing] (timing) 12.19user 0.84system 0:14.87elapsed 87%CPU (0avgtext+0avgdata 63948maxresident)k
[precise-testing] (timing) 0inputs+2632outputs (0major+106534minor)pagefaults 0swaps
Found a test script: ./plainbox/requirements/container-tests-plainbox-documentation
[precise-testing] container-tests-plainbox-documentation: PASS
[precise-testing] (timing) ...

Revision history for this message
Zygmunt Krynicki (zyga) wrote :

OK, so this fails just because we're not developing all the providers for testing, I suspect.

Unmerged revisions

3351. By Zygmunt Krynicki

plainbox:provider_manager: make new validation default

This patch updates provider manager to use the new validation subsystem
by default. Currently all of the providers maintained in lp:checkbox are
supported and it seems that nothing stays in the way of flipping the
switch.

If all goes well the old validation code will be removed in plainbox
0.16 (in one month from now).

Signed-off-by: Zygmunt Krynicki <email address hidden>

3350. By Zygmunt Krynicki

plainbox:provider_manager: modernize tests

This patch "modernizes" some of the tests to use the new-style
validation subsystem (by passing -N to ./manage.py) in anticipation to
making -N the default.

Signed-off-by: Zygmunt Krynicki <email address hidden>

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches