lp://staging/~zyga/checkbox/fix-1297928

Branch merges

Propose for merging

No branches dependent on this one.

Merged into lp://staging/checkbox at revision 2831

Daniel Manrique (community): Approve on 2014-03-26

Diff: 152 lines (+38/-6)

4 files modified

plainbox/plainbox/impl/ctrl.py (+8/-0)
plainbox/plainbox/impl/session/test_resume.py (+2/-1)
plainbox/plainbox/impl/session/test_state.py (+5/-0)
plainbox/plainbox/impl/test_ctrl.py (+23/-5)

api

Related source package recipes

No recipes using this branch. (?)

Create packaging recipe

Related snap packages

Related bugs

Bug #1297928: resuming a suspended session creates empty list of resources for resource jobs that didn't run

High

Fix Released

Link a bug report

Related blueprints

2831. By Zygmunt Krynicki on 2014-03-26

plainbox:ctrl: don't process resource jobs that didn't run

This patch changes the behavior of the session state controller not to
create resource records for job results that have outcome equal to
OUTCOME_NONE. Such job results are created automatically for every job
definition for new sessions. When resuming they would cause each
resource job to seemingly have fake resource list with no entries on it.
This causes a discrepancy between the originally suspended session and
the resulting resumed session.

Fixes: https://bugs.launchpad.net/checkbox/+bug/1297928

Signed-off-by: Zygmunt Krynicki <email address hidden>

2830. By Zygmunt Krynicki on 2014-03-26

plainbox:session:state: add outcome=IJobResult.OUTCOME_PASS to various tests

This patch prepares for small behavior change that would see those tests
fail without having outcome set to something other than OUTCOME_NONE.

Signed-off-by: Zygmunt Krynicki <email address hidden>

2829. By Zygmunt Krynicki on 2014-03-26

plainbox:session:resume: add outcome=IJobResult.OUTCOME_PASS to one test

This patch prepares for small behavior change that would see those tests
fail without having outcome set to something other than OUTCOME_NONE.

Signed-off-by: Zygmunt Krynicki <email address hidden>

2828. By Zygmunt Krynicki on 2014-03-26

plainbox:ctrl: add outcome=IJobResult.OUTCOME_PASS to various unit tests

This patch prepares for small behavior change that would see those tests
fail without having outcome set to something other than OUTCOME_NONE.

Signed-off-by: Zygmunt Krynicki <email address hidden>

2827. By Zygmunt Krynicki on 2014-03-26

"automatic merge by tarmac [r=roadmr][bug=][author=zkrynicki]"

2826. By Launchpad Translations on behalf of checkbox-dev on 2014-03-26

Launchpad automatic translations update.

2825. By Zygmunt Krynicki on 2014-03-25

"automatic merge by tarmac [r=bladernr][bug=1297337][author=zkrynicki]"

2824. By Launchpad Translations on behalf of checkbox-dev on 2014-03-25

Launchpad automatic translations update.

2823. By Daniel Manrique on 2014-03-25

"FIxes careless addition of estimated_time that duplicated the existing values, causing crashes. [r=roadmr][bug=][author=roadmr]"

2822. By Daniel Manrique on 2014-03-24

"Added execution times for resource jobs. [r=zkrynicki][bug=][author=roadmr]"