OpenStack Identity (keystone)

Merge lp://staging/~zulcss/keystone/buh-bye-dbconfig into lp://staging/~openstack-ubuntu-testing/keystone/grizzly

  1. buh-bye-dbconfig
  2. Merge into grizzly
Proposed by Chuck Short
Status: Merged
Merged at revision: 167
Proposed branch: lp://staging/~zulcss/keystone/buh-bye-dbconfig
Merge into: lp://staging/~openstack-ubuntu-testing/keystone/grizzly
Diff against target: 145 lines (+7/-77)
6 files modified
debian/changelog (+3/-0)
debian/control (+1/-2)
debian/keystone.config (+0/-19)
debian/keystone.postinst (+3/-25)
debian/keystone.postrm (+0/-14)
debian/keystone.prerm (+0/-17)
To merge this branch: bzr merge lp://staging/~zulcss/keystone/buh-bye-dbconfig
Reviewer Review Type Date Requested Status
James Page Needs Fixing
Review via email: mp+139215@code.staging.launchpad.net

Description of the change

Remove dbconfig-common from keystone.

To post a comment you must log in.
Revision history for this message
James Page (james-page) wrote :

debian/keystone.postinst, 91: typo in work connection.

review: Needs Fixing
Revision history for this message
James Page (james-page) wrote :

*word connection

Revision history for this message
Dave Walker (davewalker) wrote :

"+ * Remove dbconfig-common support, its not enabled by default anyways."

Could be better worded IMO.

Ta

Revision history for this message
James Page (james-page) wrote :

I'd probably drop "its not enabled by default anyways." as well

lp://staging/~zulcss/keystone/buh-bye-dbconfig updated
167. By Chuck Short

fix up based on comments

Revision history for this message
James Page (james-page) wrote :

Those fixes look good; I noticed that the package still contains a templates file:

E: keystone: no-debconf-config
I: keystone: unused-debconf-template keystone/configure_db

Please could you fixup; also I noticed the version number in the changelog is not sequential from the released version - please could you fix this up as well (not the fault of the MP tho).

review: Needs Fixing

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches