Glance

Merge lp://staging/~zulcss/glance/lp1307518 into lp://staging/~ubuntu-server-dev/glance/icehouse

Proposed by Chuck Short on 2014-04-14

Status:

Merged

Merged at revision:

293

Proposed branch:

Merge into:

Diff against target:

3 files modified

debian/changelog (+7/-0)
debian/glance-api.install (+1/-0)
debian/glance-common.postinst (+1/-1)

To merge this branch:

bzr merge lp://staging/~zulcss/glance/lp1307518

Related bugs:

Bug #1302044: permissions on /var/lib/glance/image* are wrong	Critical	Fix Released
Bug #1307518: ERROR "CRITICAL glance [-] AttributeError: 'NoneType' object has no attribute 'drivername'" in /var/log/glance/api.log	Undecided	Fix Released

Link a bug report

Reviewer	Review Type	Date Requested	Status
James Page		2014-04-14	Approve on 2014-04-14
Review via email: mp+215679@code.staging.launchpad.net

288. By Chuck Short on 2014-04-14: debian/glance-common.postinst: Change permissions on
/var/lib/glance/images and /var/lib/glance/image-cache
(LP: #1302044)
289. By Chuck Short on 2014-04-14: conditional chown

Revision history for this message

James Page (james-page) wrote on 2014-04-14:

Generally - use a -d instead of -e.

41 + if [ -e /var/lib/glance/image-cache]; then
42 + /var/lib/glance/image-cache
43 + fi

needs a space after (image-cache) on 41

also needs to chown glance:glance -R /var/lib/glance/image-cache

review: Needs Fixing

Revision history for this message

James Page (james-page) wrote on 2014-04-14:

"-e" -> "-d"

review: Needs Fixing

291. By Chuck Short on 2014-04-14: Revert commit
292. By Chuck Short on 2014-04-14: [ Chuck Short
* debian/glance-common.postinst: Set correct owner/group for /var/lib/glance
and subdirs only on local filesystems (LP: #1302044).
293. By Chuck Short on 2014-04-14: Fix up changelog