Merge lp://staging/~zsombi/ubuntu-ui-toolkit/expose-alarmmodel-reset into lp://staging/ubuntu-ui-toolkit/staging

Proposed by Zsombor Egri
Status: Merged
Approved by: Cris Dywan
Approved revision: 1306
Merged at revision: 1347
Proposed branch: lp://staging/~zsombi/ubuntu-ui-toolkit/expose-alarmmodel-reset
Merge into: lp://staging/ubuntu-ui-toolkit/staging
Prerequisite: lp://staging/~zsombi/ubuntu-ui-toolkit/alarm-data-adaptation
Diff against target: 56 lines (+16/-1)
3 files modified
components.api (+1/-0)
modules/Ubuntu/Components/plugin/ucalarmmodel.cpp (+12/-1)
modules/Ubuntu/Components/plugin/ucalarmmodel.h (+3/-0)
To merge this branch: bzr merge lp://staging/~zsombi/ubuntu-ui-toolkit/expose-alarmmodel-reset
Reviewer Review Type Date Requested Status
PS Jenkins bot continuous-integration Approve
Cris Dywan Approve
Review via email: mp+238802@code.staging.launchpad.net

Commit message

Expose refresh() function in revision 1 (Ubuntu.Components 1.1)

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
1303. By Zsombor Egri

prereq sync

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
Cris Dywan (kalikiana) wrote :

modules/Ubuntu/Components/plugin/ucalarmmodel.cpp:233: warning: Unrecognizable QML module/component qualifier for refresh()

It should be \qmlmethod void AlarmModel::refresh()

review: Needs Fixing
1304. By Zsombor Egri

prereq sync

1305. By Zsombor Egri

prereq sync

1306. By Zsombor Egri

prereq sync

Revision history for this message
Cris Dywan (kalikiana) wrote :

Nice! (Although I don't "like" the change… it's good for what it does ;-))

review: Approve
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) :
review: Approve (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches